Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible unique id gen #2916

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Compatible unique id gen #2916

merged 2 commits into from
Oct 14, 2024

Conversation

nlkluth
Copy link
Member

@nlkluth nlkluth commented Oct 14, 2024

Description

Removes the use of useId to remain compatible with older versions of react

Fixes # #2914

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I tested this in a simple create-vite app with react 16. I also tested in a next app to make sure the ID generated doesn't break anything with SSR. It seems safe due to the component needing to be client rendered. I don't think any other randomness-related issues should be present.

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 6:02pm

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 67869b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
victory-core Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch
rn-demo Patch
victory-native Patch
victory-vendor Patch
victory-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nlkluth nlkluth merged commit ca2b468 into main Oct 14, 2024
9 checks passed
@nlkluth nlkluth deleted the compatible-unique-id-gen branch October 14, 2024 19:25
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants