Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(#2941): hydration error using victory line on next js 15 #2973

Merged

Conversation

coston
Copy link
Contributor

@coston coston commented Nov 15, 2024

Description

🎯 ensure that uniqueId() is only called on mount to prevent hydration mismatch

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual testing with Next.js SSR and in the Victory demo app

Screenshots

Before, the svg clip-path attribute value increments with every rerender.
Kapture 2024-11-15 at 12 28 20

After, the svg clip-path attribute value does not increment, because uniqueId is not recalled.
Kapture 2024-11-15 at 12 22 09

Validated that user props still work fine
image

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 15, 2024 9:08pm

Copy link
Contributor

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 385.54KB 385.59KB +0.05KB (+0.01%)
TOTAL +0.05KB

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 074cd63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coston coston requested a review from carbonrobot November 15, 2024 19:04
@coston coston marked this pull request as ready for review November 15, 2024 19:04
@coston coston merged commit d2d5b63 into main Nov 18, 2024
7 checks passed
@coston coston deleted the fix(#2941)--hydration-error-using-VictoryLine-on-NextJS-15 branch November 18, 2024 19:28
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants