fix: table/list keyAttribute error if not unique (fixes SFKUI-6936)
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicklasWei
requested review from
ext,
dvitamin,
MCFK,
OlofFredriksson,
TMFKse,
mitra-Re and
jameseklund
as code owners
|
ext
approved these changes
Feb 17, 2025
| for (const row of this.rows) { | ||
| const rowKey = String(row[this.keyAttribute]); | ||
| if (seenKeys[rowKey]) { | ||
| const index = this.rows.indexOf(row); |
There was a problem hiding this comment.
Väldigt sällan jag rekommenderar .forEach() men här känns som en ok fall:
this.rows.forEach((row, index) => {
});Så slipper vi scanna tabellen två gånger för att hitta index (en gång för for-slingar, en gång för indexOf)
Alternativt
for (const index in this.rows) {
const row = this.rows[index];
}
dvitamin
approved these changes
Feb 17, 2025
MCFK
approved these changes
Feb 18, 2025
NicklasWei
force-pushed
the
table-key-attribute
branch
from
3ca921c to
4b64bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lägger till att
FList,FDataTableochFInteractiveTablekollar så attkeyAttributefaktiskt är unikt när items/rows ändras. Och om inte, kastar fel.