Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set --warning-mode all in prb #3190

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Set --warning-mode all in prb #3190

wants to merge 6 commits into from
+7 −7

Conversation

ScottDugas
Copy link
Collaborator

This is to help detect issues that will prevent upgrading to gradle 8

@ScottDugas
Set --warning-mode all in prb
6922961 
This is to help detect issues that will prevent upgrading to gradle 8
@ScottDugas
Remove -b ./build.gradle from actions
56c3534 
The -b option is deprecated.
I am doing this naively, but we may lose all of the configuration
in ./build.gradle, and everything will fail, in which case I'll
need more substantial changes. Or it will just work.
@ScottDugas
Copy link
Collaborator Author

ScottDugas commented Feb 24, 2025 •
edited
Loading 

The AbstractArchiveTask.archiveName property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the archiveFileName property instead. See https://docs.gradle.org/7.6.4/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archiveName for more details.
	at publishing_enr7bae7rh6zulxrel5a43sh8$_run_closure3$_closure14$_closure15.doCall(/home/runner/work/fdb-record-layer/fdb-record-layer/gradle/publishing.gradle:96)
	(Run with --stacktrace to get the full stack trace of this deprecation warning.)

https://docs.gradle.org/7.6.4/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archiveName

@ScottDugas
Copy link
Collaborator Author

Not a deprecation warning:

Execution optimizations have been disabled for task ':fdb-record-layer-jmh:generateJmhProto' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-jmh/.out/extracted-include-protos/main'. Reason: Task ':fdb-record-layer-jmh:generateJmhProto' uses this output of task ':fdb-record-layer-jmh:extractIncludeProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details about this problem.
Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-jmh/.out/extracted-include-protos/main'. Reason: Task ':fdb-record-layer-jmh:generateJmhProto' uses this output of task ':fdb-record-layer-jmh:extractIncludeProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details.

@ScottDugas
Remove usages of -Xverify:none
6443183 
This has been deprecated because it creates code that violates the
JVM specification:
https://bugs.openjdk.org/browse/JDK-8214731
@ScottDugas
Copy link
Collaborator Author

I don't see any warnings in the prb logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ScottDugas