Yaml tests: Only allow forced continuations on SELECT queries #3201
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YAML tests are forcing continuations on every query right now. This runs into issues where the underlying implementation does not support setting
maxRows
. This change prevents forced continuations from taking place in any query butSELECT
.Queries such as
UPDATE
will not reject amaxRows
but will ignore it (returning all rows) which will cause a test to fail validation when the rows returned are validated.Notes:
setup
blocks, and no validation is done, however, this will impact the way that these queries behave as wellSELECT
query begins with"select"
string, a more elaborate test can be added later