Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml tests: Only allow forced continuations on SELECT queries #3201

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ohadzeliger
Copy link
Contributor

The YAML tests are forcing continuations on every query right now. This runs into issues where the underlying implementation does not support setting maxRows. This change prevents forced continuations from taking place in any query but SELECT.
Queries such as UPDATE will not reject a maxRows but will ignore it (returning all rows) which will cause a test to fail validation when the rows returned are validated.
Notes:

  • All queries (UDPATE, INSERT, DROP etc) will now execute in "regular" mode even when forced continuation is taking place for SELECTs
  • Most data modification is taking place in the setup blocks, and no validation is done, however, this will impact the way that these queries behave as well
  • This change assumes that SELECT query begins with "select" string, a more elaborate test can be added later

@ohadzeliger ohadzeliger self-assigned this Feb 25, 2025
@ohadzeliger ohadzeliger added the testing improvement Change that improves our testing label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing improvement Change that improves our testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant