Skip to content

Commit 1054850

Browse files
author
Hector Oliveros
committed
Update connection limit logging to check for changes
Added conditionals to log limit updates only when changes are detected, reducing unnecessary log noise. This applies to both server and client limit updates in the connection logic.
1 parent b1cfae3 commit 1054850

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

asyncua/common/connection.py

+16-1
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,18 @@ def create_acknowledge_and_set_limits(self, msg: ua.Hello) -> ua.Acknowledge:
5454
ack.SendBufferSize = min(msg.SendBufferSize, self.max_recv_buffer)
5555
ack.MaxChunkCount = self._select_limit(msg.MaxChunkCount, self.max_chunk_count)
5656
ack.MaxMessageSize = self._select_limit(msg.MaxMessageSize, self.max_message_size)
57+
have_changes = (
58+
self.max_chunk_count != ack.MaxChunkCount or
59+
self.max_recv_buffer != ack.ReceiveBufferSize or
60+
self.max_send_buffer != ack.SendBufferSize or
61+
self.max_message_size != ack.MaxMessageSize
62+
)
63+
if have_changes:
64+
_logger.info("updating server limits to: %s", self)
5765
self.max_chunk_count = ack.MaxChunkCount
5866
self.max_recv_buffer = ack.SendBufferSize
5967
self.max_send_buffer = ack.ReceiveBufferSize
6068
self.max_message_size = ack.MaxMessageSize
61-
_logger.info("updating server limits to: %s", self)
6269
return ack
6370

6471
def create_hello_limits(self, msg: ua.Hello) -> ua.Hello:
@@ -69,6 +76,14 @@ def create_hello_limits(self, msg: ua.Hello) -> ua.Hello:
6976
return msg
7077

7178
def update_client_limits(self, msg: ua.Acknowledge) -> None:
79+
have_changes = (
80+
self.max_chunk_count != msg.MaxChunkCount or
81+
self.max_recv_buffer != msg.ReceiveBufferSize or
82+
self.max_send_buffer != msg.SendBufferSize or
83+
self.max_message_size != msg.MaxMessageSize
84+
)
85+
if have_changes:
86+
_logger.info("updating client limits to: %s", self)
7287
self.max_chunk_count = msg.MaxChunkCount
7388
self.max_recv_buffer = msg.ReceiveBufferSize
7489
self.max_send_buffer = msg.SendBufferSize

0 commit comments

Comments
 (0)