Fix Nodeclass in ReferenceDescriptions of UA-Nodeset #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate_address_space.py used old address space for pickle generation, which means you had to run it twice to get the new one
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1529.
Add references after all nodes has been processed, when we know the respective NodeClass of the TargetNode. Reused schema version 1.05.01, to not introduce additional changes to the address space.
I also fixed the generation of binary_address_space.pickle, which probably wasn't up-to-date before, unless the generator has been run twice. Not sure if this file is needed at all, at least it's not used by asyncua itself.