From a64c2ed410328b296629d9dc1bcca82ae6c61d15 Mon Sep 17 00:00:00 2001 From: kar-rahul-aws Date: Tue, 9 Apr 2024 17:30:32 +0530 Subject: [PATCH 1/2] Remove unwanted volatile keyword --- tasks.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tasks.c b/tasks.c index e0db3f9e72..9b56eb1a43 100644 --- a/tasks.c +++ b/tasks.c @@ -6255,7 +6255,6 @@ static void prvCheckTasksWaitingTermination( void ) List_t * pxList, eTaskState eState ) { - configLIST_VOLATILE TCB_t * pxTCB; UBaseType_t uxTask = 0; const ListItem_t * pxEndMarker = listGET_END_MARKER( pxList ); ListItem_t * pxIterator; @@ -6271,7 +6270,7 @@ static void prvCheckTasksWaitingTermination( void ) /* MISRA Ref 11.5.3 [Void pointer assignment] */ /* More details at: https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/MISRA.md#rule-115 */ /* coverity[misra_c_2012_rule_11_5_violation] */ - pxTCB = listGET_LIST_ITEM_OWNER( pxIterator ); + TCB_t * pxTCB = listGET_LIST_ITEM_OWNER( pxIterator ); vTaskGetInfo( ( TaskHandle_t ) pxTCB, &( pxTaskStatusArray[ uxTask ] ), pdTRUE, eState ); uxTask++; From fced4a98969a671a4a0ef1ca569a803e34d9b1fb Mon Sep 17 00:00:00 2001 From: kar-rahul-aws Date: Wed, 10 Apr 2024 17:56:33 +0530 Subject: [PATCH 2/2] Declare variable initially --- tasks.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tasks.c b/tasks.c index 9b56eb1a43..b026160263 100644 --- a/tasks.c +++ b/tasks.c @@ -985,6 +985,7 @@ static void prvAddNewTaskToReadyList( TCB_t * pxNewTCB ) PRIVILEGED_FUNCTION; UBaseType_t uxCurrentPriority = uxTopReadyPriority; BaseType_t xTaskScheduled = pdFALSE; BaseType_t xDecrementTopPriority = pdTRUE; + TCB_t * pxTCB = NULL; #if ( configUSE_CORE_AFFINITY == 1 ) const TCB_t * pxPreviousTCB = NULL; @@ -1043,7 +1044,7 @@ static void prvAddNewTaskToReadyList( TCB_t * pxNewTCB ) PRIVILEGED_FUNCTION; /* MISRA Ref 11.5.3 [Void pointer assignment] */ /* More details at: https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/MISRA.md#rule-115 */ /* coverity[misra_c_2012_rule_11_5_violation] */ - TCB_t * pxTCB = ( TCB_t * ) listGET_LIST_ITEM_OWNER( pxIterator ); + pxTCB = ( TCB_t * ) listGET_LIST_ITEM_OWNER( pxIterator ); #if ( configRUN_MULTIPLE_PRIORITIES == 0 ) { @@ -4181,6 +4182,7 @@ char * pcTaskGetName( TaskHandle_t xTaskToQuery ) const char pcNameToQuery[] ) { TCB_t * pxReturn = NULL; + TCB_t * pxTCB = NULL; UBaseType_t x; char cNextChar; BaseType_t xBreakLoop; @@ -4196,7 +4198,7 @@ char * pcTaskGetName( TaskHandle_t xTaskToQuery ) /* MISRA Ref 11.5.3 [Void pointer assignment] */ /* More details at: https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/MISRA.md#rule-115 */ /* coverity[misra_c_2012_rule_11_5_violation] */ - TCB_t * pxTCB = listGET_LIST_ITEM_OWNER( pxIterator ); + pxTCB = listGET_LIST_ITEM_OWNER( pxIterator ); /* Check each character in the name looking for a match or * mismatch. */ @@ -6258,6 +6260,7 @@ static void prvCheckTasksWaitingTermination( void ) UBaseType_t uxTask = 0; const ListItem_t * pxEndMarker = listGET_END_MARKER( pxList ); ListItem_t * pxIterator; + TCB_t * pxTCB = NULL; if( listCURRENT_LIST_LENGTH( pxList ) > ( UBaseType_t ) 0 ) { @@ -6270,7 +6273,7 @@ static void prvCheckTasksWaitingTermination( void ) /* MISRA Ref 11.5.3 [Void pointer assignment] */ /* More details at: https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/MISRA.md#rule-115 */ /* coverity[misra_c_2012_rule_11_5_violation] */ - TCB_t * pxTCB = listGET_LIST_ITEM_OWNER( pxIterator ); + pxTCB = listGET_LIST_ITEM_OWNER( pxIterator ); vTaskGetInfo( ( TaskHandle_t ) pxTCB, &( pxTaskStatusArray[ uxTask ] ), pdTRUE, eState ); uxTask++;