From ee2ee4dc7ce9a0ff4a44d37768a1a88db7778de9 Mon Sep 17 00:00:00 2001 From: Stefan Date: Mon, 3 Mar 2025 08:43:10 +0100 Subject: [PATCH 1/3] Fix add overflow check on recursive mutex counter --- queue.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/queue.c b/queue.c index e91d9e39be..5f17d440d6 100644 --- a/queue.c +++ b/queue.c @@ -833,6 +833,10 @@ static void prvInitialiseNewQueue( const UBaseType_t uxQueueLength, if( pxMutex->u.xSemaphore.xMutexHolder == xTaskGetCurrentTaskHandle() ) { ( pxMutex->u.xSemaphore.uxRecursiveCallCount )++; + + /* check if an overflow occurred */ + configASSERT( pxMutex->u.xSemaphore.uxRecursiveCallCount ); + xReturn = pdPASS; } else From 51f6b0082a3e4f05cd3be49568f68757be8e1190 Mon Sep 17 00:00:00 2001 From: Gaurav Aggarwal Date: Tue, 4 Mar 2025 07:28:38 +0000 Subject: [PATCH 2/3] Code review suggestions Signed-off-by: Gaurav Aggarwal --- queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/queue.c b/queue.c index 5f17d440d6..1077068ef5 100644 --- a/queue.c +++ b/queue.c @@ -834,7 +834,7 @@ static void prvInitialiseNewQueue( const UBaseType_t uxQueueLength, { ( pxMutex->u.xSemaphore.uxRecursiveCallCount )++; - /* check if an overflow occurred */ + /* Check if an overflow occurred. */ configASSERT( pxMutex->u.xSemaphore.uxRecursiveCallCount ); xReturn = pdPASS; From b98a2d238b290eb1d9d78fdc7df671684c75f077 Mon Sep 17 00:00:00 2001 From: Gaurav Aggarwal Date: Tue, 4 Mar 2025 09:12:50 +0000 Subject: [PATCH 3/3] Code review suggestion Signed-off-by: Gaurav Aggarwal --- queue.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/queue.c b/queue.c index 1077068ef5..fe06368d3a 100644 --- a/queue.c +++ b/queue.c @@ -849,6 +849,9 @@ static void prvInitialiseNewQueue( const UBaseType_t uxQueueLength, if( xReturn != pdFAIL ) { ( pxMutex->u.xSemaphore.uxRecursiveCallCount )++; + + /* Check if an overflow occurred. */ + configASSERT( pxMutex->u.xSemaphore.uxRecursiveCallCount ); } else {