Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: added missing deallocations #636

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ProjectMutilation
Copy link
Contributor

No description provided.

Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>
@ProjectMutilation
Copy link
Contributor Author

@freddy77 could you please help with the review?

@freddy77
Copy link
Contributor

freddy77 commented Feb 6, 2025

@freddy77 could you please help with the review?

What do you mean ? Any doubt ?

@ProjectMutilation
Copy link
Contributor Author

ProjectMutilation commented Feb 7, 2025

@freddy77 could you please help with the review?

What do you mean ? Any doubt ?

I'm not sure if when a tds_alloc_connection() is failed inside tds_alloc_socket(), the conn->tds_ctx is not released somewhere and tds_free_context(context); will not be the reason for the double free

@freddy77
Copy link
Contributor

freddy77 commented Feb 7, 2025

@freddy77 could you please help with the review?

What do you mean ? Any doubt ?

I'm not sure if when a tds_alloc_connection() is failed inside tds_alloc_socket(), the conn->tds_ctx is not released somewhere and tds_free_context(context); will not be the reason for the double free

Fine as it is.

@freddy77 freddy77 merged commit 6737300 into FreeTDS:master Feb 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants