Add PDF generation feature #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #19 Add feature to save Medium articles as PDFs. * **Backend Changes:** - Add a new endpoint `generate_pdf` in `web/server/handlers/post.py` to handle PDF generation requests. - Import `WeasyPrint` for rendering HTML to PDF. - Update the `render_medium_post_link` function to support PDF generation. * **Template Changes:** - Ensure compatibility with PDF rendering by adjusting styles in `web/server/templates/post.html`. - Add a hidden div with the article content for PDF generation. * **Frontend Changes:** - Add a "Save as PDF" button in `new-web/src/routes/[slug]/+page.svelte` to trigger the PDF generation. - Implement a function to call the new PDF generation endpoint. * **Documentation:** - Update `README.md` to include instructions for the new PDF generation feature. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Freedium-cfd/web/issues/19?shareId=XXXX-XXXX-XXXX-XXXX).
|
Hey. Thanks for the PR. |
ZhymabekRoman
requested changes
Oct 27, 2024
| from html5lib import serialize | ||
| from html5lib.html5parser import parse | ||
| from async_lru import alru_cache | ||
| from loguru import logger | ||
| from medium_parser import medium_parser_exceptions | ||
| from weasyprint import HTML |
There was a problem hiding this comment.
Please add weasyprint as a dependency
| @@ -114,3 +114,10 @@ <h1 class="font-bold font-sans break-normal text-gray-900 dark:text-gray-100 pt- | |||
| cursor: pointer; | |||
| } | |||
| </style> | |||
| <div id="pdf-content" style="display: none;"> | |||
There was a problem hiding this comment.
didn't understand what is this
| return HTMLResponse(serialized_rendered_post) | ||
|
|
||
|
|
||
| async def generate_pdf(path: str): |
There was a problem hiding this comment.
I don't see endpoint registration
| @@ -68,6 +68,19 @@ Stay tuned for more exciting updates as we continue to revolutionize the world o | |||
| contentLoaded = true; | |||
| }, 500); | |||
| }); | |||
|
|
|||
| async function saveAsPDF() { | |||
There was a problem hiding this comment.
Nahhh, this should be definetly refactored
|
Closed with no response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Add feature to save Medium articles as PDFs.
Backend Changes:
generate_pdfinweb/server/handlers/post.pyto handle PDF generation requests.WeasyPrintfor rendering HTML to PDF.render_medium_post_linkfunction to support PDF generation.Template Changes:
web/server/templates/post.html.Frontend Changes:
new-web/src/routes/[slug]/+page.svelteto trigger the PDF generation.Documentation:
README.mdto include instructions for the new PDF generation feature.For more details, open the Copilot Workspace session.