Merge pull request #22 from pamil/symfony4

Add support for Symfony 4

Author: pamil

.travis.yml

@@ -5,30 +5,23 @@ php:
     - 7.2
 
 env:
-    matrix:
-        - PREFER_LOWEST="--prefer-lowest"
-        - PREFER_LOWEST=""
+    - SYMFONY_VERSION=3.3.*
+    - SYMFONY_VERSION=3.4.*
+    - SYMFONY_VERSION=4.0.*
 
 cache:
     directories:
-        - vendor
+        - ~/.composer/cache/files
 
 before_install:
     - phpenv config-rm xdebug.ini || true
 
 install:
-    - composer update --prefer-dist $PREFER_LOWEST
+    - composer require symfony/dependency-injection:${SYMFONY_VERSION} --no-update --no-scripts --prefer-dist
+    - composer update --prefer-dist
 
 script:
     - composer validate --strict
 
     - vendor/bin/phpspec run --format dot -vvv --no-interaction
     - vendor/bin/behat --strict -vvv --no-interaction
-
-jobs:
-    include:
-        -   stage: Code Standard Checker
-            php: 7.1
-
-            script:
-                - vendor/bin/ecs check src spec

composer.json

@@ -13,13 +13,12 @@
         "php": "^7.1",
 
         "behat/behat": "^3.1",
-        "symfony/dependency-injection": "^3.0|^4.0"
+        "symfony/dependency-injection": "^3.3|^4.0"
     },
     "require-dev": {
         "friends-of-behat/cross-container-extension": "^1.0",
         "friends-of-behat/test-context": "^1.0",
-        "phpspec/phpspec": "^4.0",
-        "sylius-labs/coding-standard": "^1.0"
+        "phpspec/phpspec": "^4.0"
     },
     "suggest": {
         "friends-of-behat/cross-container-extension": "^1.0",

src/ServiceContainer/Scenario/ContextRegistryPass.php

@@ -45,6 +45,8 @@ public function process(ContainerBuilder $container): void
         $taggedServices = $container->findTaggedServiceIds(self::CONTEXT_SERVICE_TAG);
 
         foreach ($taggedServices as $id => $tags) {
+            $container->getDefinition($id)->setPublic(true);
+
             $this->contextRegistryDefinition->addMethodCall(
                 'add',
                 [$id, $container->findDefinition($id)->getClass()]