Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medium embeddings are broken in some cases #42

Open
jslirola opened this issue May 25, 2024 · 0 comments
Open

Medium embeddings are broken in some cases #42

jslirola opened this issue May 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jslirola
Copy link

Bug Report

Current Behavior
I have encountered two issues related to formatting Medium links.

Error loading images
When attempting to load an image from a Medium link, a 404 error is returned. This prevents images from displaying correctly in the content.

Example of affected URL:
https://medium.com/ssense-tech/hexagonal-architecture-there-are-always-two-sides-to-every-story-bc0780ed7d9c

error1

Problem with special characters (accents)
When a Medium URL contains special characters in Spanish, such as accents (e.g., "cómo"), the URL is not formatted correctly. The first 'ó' gets converted into encoded characters, resulting in a non-functional link.

Example of affected URL:
https://medium.com/datapath/c%C3%B3mo-usar-read-ai-transcribe-y-mejora-tus-reuniones-virtuales-93ca8cc3ba66

error2

Expected Behavior
I expected to see a preview of the links. In the first case it is formatted but without the image, in the second nothing is shown other than the iframe without content.

Environment

  • Flarum version: 1.8.1
  • Extension version: 1.0.3
  • Webserver: apache
  • Hosting environment: shared
  • PHP version: 8.2.18
  • Browser: firefox 125.0.3
+-------------------------------------------+---------+------------------------------------------+
| Flarum Extensions                         |         |                                          |
+-------------------------------------------+---------+------------------------------------------+
| ID                                        | Version | Commit                                   |
+-------------------------------------------+---------+------------------------------------------+
| flarum-likes                              | v1.8.0  |                                          |
| flarum-flags                              | v1.8.0  |                                          |
| antoinefr-money                           | v1.3.1  |                                          |
| flarum-sticky                             | v1.8.0  |                                          |
| flarum-tags                               | v1.8.0  |                                          |
| flarum-markdown                           | v1.8.0  |                                          |
| flarum-suspend                            | v1.8.0  |                                          |
| flarum-lock                               | v1.8.0  |                                          |
| flarum-approval                           | v1.8.0  |                                          |
| afrux-forum-widgets-core                  | v0.1.7  |                                          |
| flamarkt-backoffice                       | 0.1.3   |                                          |
| ziiven-money-leaderboard                  | v0.1.7  |                                          |
| zerosonesfun-direct-links                 | 3.1     |                                          |
| zerosonesfun-composer-preview             | 1.2     |                                          |
| v17development-seo                        | v1.8.0  |                                          |
| the-turk-stickiest                        | 2.0.3   |                                          |
| sycho-move-posts                          | v0.1.7  |                                          |
| rob006-last-post-avatar                   | 1.2.4   |                                          |
| michaelbelgium-discussion-views           | v7.2.1  |                                          |
| matteocontrini-imgur-upload               | v3.9.1  |                                          |
| maicol07-sso                              | 1.11.5  |                                          |
| kilowhat-audit-free                       | 1.6.0   |                                          |
| justoverclock-welcomebox                  | 1.3.8   |                                          |
| justoverclock-related-discussions         | 1.3.4   |                                          |
| justoverclock-hot-discussions             | 0.1.2   |                                          |
| justoverclock-custom-html-widget          | 0.1.4   |                                          |
| fof-webhooks                              | 1.2.3   |                                          |
| fof-user-bio                              | 1.3.2   |                                          |
| fof-terms                                 | 1.2.1   |                                          |
| fof-sitemap                               | 1.0.3   |                                          |
| fof-share-social                          | 1.2.0   |                                          |
| fof-sentry                                | 1.3.2   |                                          |
| fof-recaptcha                             | 1.3.2   |                                          |
| fof-pretty-mail                           | 1.1.1   |                                          |
| fof-nightmode                             | 1.5.2   |                                          |
| fof-masquerade                            | 2.1.4   |                                          |
| fof-links                                 | 1.2.2   |                                          |
| fof-linguist                              | 1.1.1   |                                          |
| fof-forum-statistics-widget               | 1.2.1   |                                          |
| fof-formatting                            | 1.0.3   |                                          |
| fof-disposable-emails                     | 1.0.0   |                                          |
| fof-default-user-preferences              | 1.2.0   |                                          |
| fof-cookie-consent                        | 1.1.1   |                                          |
| flarum-subscriptions                      | v1.8.0  |                                          |
| flarum-statistics                         | v1.8.0  |                                          |
| flarum-mentions                           | v1.8.0  |                                          |
| flarum-lang-spanish                       | 1.8.0   |                                          |
| flarum-emoji                              | v1.8.0  |                                          |
| flarum-bbcode                             | v1.8.0  |                                          |
| davwheat-ads                              | 1.2.0   |                                          |
| datlechin-link-preview                    | v1.4.0  |                                          |
| clarkwinkelmann-post-stream-search        | 1.1.0   |                                          |
| clarkwinkelmann-post-permissions          | 1.0.0   |                                          |
| clarkwinkelmann-first-post-approval       | 1.0.1   |                                          |
| clarkwinkelmann-emojionearea              | 1.0.0   |                                          |
| clarkwinkelmann-author-change             | 1.0.3   |                                          |
| clarkwinkelmann-advanced-search-highlight | 1.0.2   | 7ced2d62976bc24f7d49c7a631534a5a1ac02913 |
| askvortsov-discussion-templates           | v0.8.3  |                                          |
| askvortsov-categories                     | v3.0.9  |                                          |
+-------------------------------------------+---------+------------------------------------------+

Additional Context

I have searched the repository for similar issues and found this link, I don't think it is caused by another extension but perhaps I am wrong.

@jslirola jslirola added the bug Something isn't working label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant