Skip to content

Add Preferred languages to Application Registration Configuration #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 28, 2023

Conversation

spwitt
Copy link
Contributor

@spwitt spwitt commented Feb 17, 2023

Add preferredLanguages to ApplicationRegistrationConfiguration APIs. Update screenshot.

Site Issue:

Related Issue:

@spwitt spwitt requested review from mooreds and robotdan February 17, 2023 15:12
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update this tutorial with a new screenshot? https://fusionauth.io/docs/v1/tech/guides/basic-registration-forms

Not sure if this should be documented here, but what does the preferred languages field look like? is it the same as the locale selector? How do I control what shows up there?

@spwitt
Copy link
Contributor Author

spwitt commented Mar 13, 2023

@mooreds updated the guide screenshot.

The selection uses https://fusionauth.io/docs/v1/tech/reference/data-types#locales

There is no way to configure which locales appear in the list similar to the existing preferred languages dropdown.

@spwitt spwitt requested a review from mooreds March 13, 2023 16:21
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested.

Co-authored-by: Dan Moore <github@mooreds.com>
@mooreds
Copy link
Contributor

mooreds commented Apr 3, 2023

Is this ready to merge, @spwitt ?

@mooreds
Copy link
Contributor

mooreds commented Apr 3, 2023

Or is this waiting for 1.45? Oops, looks like it is.

@mooreds
Copy link
Contributor

mooreds commented Jun 30, 2023

Would be awesome if this made it into 1.47.

@spwitt spwitt merged commit ebf236a into master Jul 28, 2023
@spwitt spwitt deleted the spencer/1943/preferredLanguages branch July 28, 2023 13:12
@mooreds
Copy link
Contributor

mooreds commented Jul 28, 2023

@spwitt super exciting! This is great for folks who are on the community version and want to make sure their initial emails are sent out in the correct language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants