fix: type coercion in TU/e-username year check

Co-Authored-By: Rink <rinkp@users.noreply.github.com>
GEWIS · Sep 2, 2024 · 0c98247 · 0c98247
1 parent bf75a25
commit 0c98247
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/module/Database/src/Form/Member.php b/module/Database/src/Form/Member.php
@@ -30,6 +30,7 @@
 use Throwable;
 
 use function date;
+use function intval;
 use function preg_match;
 use function str_ends_with;
 use function substr;
@@ -432,8 +433,8 @@ private function isNewTueUsernameValid(string $value): bool
                 return true;
             }
 
-            $year = substr($value, 0, 4);
-            $currentYear = date('Y');
+            $year = intval(substr($value, 0, 4));
+            $currentYear = intval(date('Y'));
 
             // Check if the year is within the valid range, the assumption being that you can never have a number
             // starting with a year that is higher than the current year.

diff --git a/module/Database/src/Form/MemberEdit.php b/module/Database/src/Form/MemberEdit.php
@@ -23,6 +23,7 @@
 use Throwable;
 
 use function date;
+use function intval;
 use function preg_match;
 use function substr;
 
@@ -251,8 +252,8 @@ private function isNewTueUsernameValid(string $value): bool
                 return true;
             }
 
-            $year = substr($value, 0, 4);
-            $currentYear = date('Y');
+            $year = intval(substr($value, 0, 4));
+            $currentYear = intval(date('Y'));
 
             // Check if the year is within the valid range, the assumption being that you can never have a number
             // starting with a year that is higher than the current year.