Merge pull request #440 from tomudding/feature/more-restrictive-valid…

…ation-tue-usernames feat: additional validity checks for TU/e-usernames starting with a year
GEWIS · Sep 2, 2024 · ee89eea · ee89eea
2 parents 34dfc26 + f7034a4
commit ee89eea
Show file tree

Hide file tree

Showing 4 changed files with 67 additions and 7 deletions.
diff --git a/module/Application/language/en.po b/module/Application/language/en.po
diff --git a/module/Application/language/gewisdb.pot b/module/Application/language/gewisdb.pot
diff --git a/module/Application/language/nl.po b/module/Application/language/nl.po
diff --git a/module/Database/src/Form/Member.php b/module/Database/src/Form/Member.php
@@ -29,7 +29,10 @@
 use Laminas\Validator\StringLength;
 use Throwable;
 
+use function date;
+use function preg_match;
 use function str_ends_with;
+use function substr;
 
 class Member extends Form implements InputFilterProviderInterface
 {
@@ -399,6 +402,20 @@ public function getInputFilterSpecification(): array
                             ],
                         ],
                     ],
+                    [
+                        'name' => Callback::class,
+                        'options' => [
+                            'callback' => function ($value) {
+                                return $this->isNewTueUsernameValid($value);
+                            },
+                            'messages' => [
+                                Callback::INVALID_VALUE => $this->translator->translate(
+                                    // phpcs:ignore -- user-visible strings should not be split
+                                    'Your TU/e-username appears to be incorrect. Ensure that it starts with a valid year and looks like: YYYYxxxx. If you believe your TU/e-username is correct, please contact the secretary.',
+                                ),
+                            ],
+                        ],
+                    ],
                 ],
                 'filters' => [
                     ['name' => ToNull::class],
@@ -407,6 +424,25 @@ public function getInputFilterSpecification(): array
         ];
     }
 
+    private function isNewTueUsernameValid(string $value): bool
+    {
+        try {
+            // Only check for YYYYABCD TU/e usernames.
+            if (preg_match('/^s\d{6}$/', $value)) {
+                return true;
+            }
+
+            $year = substr($value, 0, 4);
+            $currentYear = date('Y');
+
+            // Check if the year is within the valid range, the assumption being that you can never have a number
+            // starting with a year that is higher than the current year.
+            return $year >= 2000 && $year <= $currentYear;
+        } catch (Throwable) {
+            return false;
+        }
+    }
+
     private function isOldEnough(string $value): bool
     {
         try {