Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for searching for meetings. #365

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

Aarhunt
Copy link
Contributor

@Aarhunt Aarhunt commented Jan 5, 2024

I added functionality for searching for meetings, to use for another issue. The previous endpoint meeting/search is repurposed for searching meetings, where searching for decisions is replaced to meeting/decision/search.

Copy link
Member

@rinkp rinkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@rinkp
Copy link
Member

rinkp commented Jan 5, 2024

@tomudding, this was meant as a step towards GH-343 where you can approve minutes but need a search for meetings to select what meeting to approve the minutes of

@Aarhunt Aarhunt force-pushed the feature/meetingsearch-endpoint branch from 38372d0 to f9f20c8 Compare January 6, 2024 15:06
@Aarhunt Aarhunt requested a review from rinkp February 17, 2024 09:46
@rinkp rinkp force-pushed the feature/meetingsearch-endpoint branch from f9f20c8 to 97d459a Compare February 17, 2024 10:30
@rinkp
Copy link
Member

rinkp commented Feb 17, 2024

@tomudding, ignore Psalm here since we have GH-368?

@rinkp rinkp merged commit d65782c into GEWIS:main Feb 17, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Feb 17, 2024
Rink: Merge pull request #365 from Aarhunt/feature/meetingsearch-endpoint

Added functionality for searching for meetings.

Co-authored-by: rinkp <rinkp@users.noreply.github.com>
@Aarhunt Aarhunt deleted the feature/meetingsearch-endpoint branch May 28, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants