Improve machine-readability of openapi.yaml
#426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JustSamuel, can you verify this works with your typescript client? I think this will make the method names less prone to change as well. |
tomudding
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
I am merely a human, so I wondered whether I was in the best position to review the spec's machine-readability. As such, I asked a computer program to check the specs too, and we both agreed that it could successfully produce an API client (and is thus correctly formatted and interpreted).
rinkp
requested review from
JustSamuel and
Yoronex
and removed request for
JustSamuel
|
@JustSamuel @Yoronex please review... |
Yoronex
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
lgtm, but I am not familiar with the GEWISDB-SudoSOS integration, so I prefer @JustSamuel to also take a look.
JustSamuel
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openapi.yamlby giving objects titles, reusing objects and reducing the number of modelsTypes of changes