-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main #40
Open
Gijsdeman
wants to merge
11
commits into
master
Choose a base branch
from
main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`corepack enable` required to ensure you are on the right yarn version.
Skipping: - tsoa: knowing this has breaking changes, will be for later - eslint: knowing we will switch later to the centralized eslint configs - typescript: switching to newer version later; as it also requires upgrading express types
TODO: switch branch to main branch
bcb9c8d
to
5532ed1
Compare
e960471
to
b1dedd3
Compare
Can't we just rename the |
Since the workflows had to be rewritten either way, just naming this branch Since the branch exists with the latest changes on it, it will likely be easiest to simply mark this as the new main branch after approved rather than merging it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR mainly consists of platform updates that should enhance the work and release flow. Rather then merging to master; should become the new main branch.
I wanted to update move
eslint
to use the@gewis/eslint-config-typescript
. However, this config uses type information and causes a lot of errors on the repository. I will address this in a separate PR.Most file changes stem from
prettier
. This is added sincets-eslint
no longer supports stylistic rules. Everything but the last commit can be checked without having to scroll through all the files.Types of changes