fix(dashboard): payout info not showing approvedBy and improve styl…

…ing (#501)
GEWIS · Feb 10, 2025 · 9b118e0 · 9b118e0
1 parent 986d927
commit 9b118e0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/apps/dashboard/src/locales/en/modules/financial.json b/apps/dashboard/src/locales/en/modules/financial.json
@@ -63,8 +63,8 @@
         "title": "Payout overview",
         "create": "Create payout",
         "requestedBy": "Requested by",
-        "details": "Payout details",
-        "approvedBy": "Approved by",
+        "details": "Payout details #{payoutId}",
+        "approvedBy": "Approved by {approvedBy}",
         "approve": "Approve",
         "deny": "Deny"
       },

diff --git a/apps/dashboard/src/locales/nl/modules/financial.json b/apps/dashboard/src/locales/nl/modules/financial.json
@@ -63,8 +63,8 @@
         "title": "Uitbetalingsoverzicht",
         "create": "Uitbetaling aanmaken",
         "requestedBy": "Aangevraagd door",
-        "details": "Uitbetalingsdetails",
-        "approvedBy": "Goedgekeurd door",
+        "details": "Uitbetalingsdetails #{payoutId}",
+        "approvedBy": "Goedgekeurd door {approvedBy}",
         "approve": "Goedkeuren",
         "deny": "Afwijzen"
       },

diff --git a/apps/dashboard/src/modules/financial/components/payout/PayoutInfo.vue b/apps/dashboard/src/modules/financial/components/payout/PayoutInfo.vue
@@ -44,7 +44,6 @@
       <div class="flex flex-column">
         <span>{{ t('common.createdAt') + ': ' }}{{ formatDateFromString(payout.createdAt) }}</span>
         <span>{{ t('common.updatedAt') + ': ' }}{{ formatDateFromString(payout.updatedAt) }}</span>
-        <span>{{ t('common.id') + ': ' }}{{ payout.id }}</span>
       </div>
     </div>
     <div v-if="isApproved && payout.approvedBy" class="mt-1">

diff --git a/apps/dashboard/src/modules/financial/components/payout/PayoutTable.vue b/apps/dashboard/src/modules/financial/components/payout/PayoutTable.vue
@@ -66,7 +66,7 @@
         v-model:visible="showModal"
         :draggable="false"
         class="w-auto flex w-9 md:w-4"
-        :header="t('modules.financial.payout.details')">
+        :header="t('modules.financial.payout.details', { payoutId })">
       <PayoutInfo :payoutId="payoutId" @close="showModal = false"/>
     </Dialog>
   </div>