Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(dashboard): forms #231

Closed
wants to merge 4 commits into from
Closed

Refactor(dashboard): forms #231

wants to merge 4 commits into from

Conversation

JustSamuel
Copy link
Contributor

@JustSamuel JustSamuel commented Jun 23, 2024 •
edited
Loading

Description

This PR provides an example and implementation of a new way to structure form creation.

Related issues/external references

#216
#15

Types of changes

  • New feature (non-breaking change which adds functionality)

@JustSamuel JustSamuel requested a review from SuperVK June 23, 2024 13:28
@JustSamuel
Copy link
Contributor Author

@SuperVK @CodeNamedRobin This PR is also for discussion.

Any suggestions on moving the submission code to the form component? I think we can also generalize the creating of toasts.

SuperVK
SuperVK approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@SuperVK SuperVK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the benefit in it, I would like to see an issue that tracks all the places where this is needed, otherwise we get even more random different implementations.

SuperVK
SuperVK approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@SuperVK SuperVK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the benefit in it, I would like to see an issue that tracks all the places where this is needed, otherwise we get even more random different implementations.

@SuperVK
Copy link
Member

SuperVK commented Jun 24, 2024

Thank you Github

@JustSamuel JustSamuel force-pushed the develop branch 3 times, most recently from 2771939 to e281694 Compare June 24, 2024 16:15
@JustSamuel JustSamuel mentioned this pull request Jul 30, 2024
Closed
@JustSamuel JustSamuel closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperVK SuperVK SuperVK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustSamuel @SuperVK