Fix(pos): styling #234
Merged
Fix(pos): styling #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperVK
approved these changes
Jun 24, 2024
JustSamuel
force-pushed
the
develop
branch
3 times, most recently
from
2771939 to
e281694
Compare
JustSamuel
force-pushed
the
fix/pos-styling
branch
from
0fdbf80 to
0a9d58e
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The product display is now actually a grid again, nicely spacing out the products over the full width. Note, I increased the amount of product columns for PCGEWISC/D and the tablet to 5. Also fixed an issue where the scroll of products would not be reset if you change categories or search something.
@SuperVK this might be a place where AB testing would be nice, as I am uncertain how the 4 vs 5 products would feel like.
Types of changes