Feature/Refactor: product forms #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperVK
force-pushed
the
feature/improved-seller
branch
from
9f9102e to
785da03
Compare
apps/dashboard/src/components/container/ContainerActionsDialog.vue
Outdated
Show resolved
Hide resolved
SuperVK
force-pushed
the
fix/product-form
branch
from
6e10205 to
1373e3e
Compare
|
Rebased and should be good now! |
CodeNamedRobin
requested changes
Aug 26, 2024
apps/dashboard/src/modules/seller/components/ProductActionExistingProductForm.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/seller/components/ProductActionExistingProductForm.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/seller/components/ProductActionExistingProductForm.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/seller/components/ProductActionExistingProductForm.vue
Outdated
Show resolved
Hide resolved
SuperVK
force-pushed
the
fix/product-form
branch
from
1a9c078 to
eeefedd
Compare
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: this pull request should be merged after #229
Refactor products forms to use the new form way, increases stability and uniform design, while preserving the reactivity that the product dialogs had. Also introduces a delete button for products.
Description
Mostly behavior is the same, slight changes is the ability to delete products. In container context they only remove from the container, without a container context they will delete the product, behind a confirm dialog.
Also fixed two bugs (#300 and #308).
Related issues/external references
#273 (one of many)
Closes #308
Closes #300
#263 (one of few)
Types of changes