Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove author landing page and metadata (authors D-E) #8374

Merged
merged 8 commits into from
Mar 4, 2025
Merged

Remove author landing page and metadata (authors D-E) #8374

merged 8 commits into from
Mar 4, 2025

Conversation

nick-mon1
Copy link
Contributor

@nick-mon1 nick-mon1 commented Feb 3, 2025 •
edited
Loading

Summary

Metadata removal for author ranges D-E.

Note

Will be merged into #8216 and also includes author removal for authors with no published content.

Solution

Removes all other author fields.

Fields to Keep

  • display_name
  • first_name
  • last_name
  • agency_full_name
  • github (github username)
  • profile_source (digit-light, digit-dark, blank)

How To Test

  1. Only fields listed above are displayed
  2. Remove non-published authors

@nick-mon1 nick-mon1 changed the base branch from main to nl-remove-author-data-b-to-c February 3, 2025 18:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

🔍 Preview in Federalist

@nick-mon1 nick-mon1 self-assigned this Feb 3, 2025
@nick-mon1 nick-mon1 mentioned this pull request Feb 3, 2025
Merged
bonnieAcameron
bonnieAcameron reviewed Feb 5, 2025
View reviewed changes
content/authors/donna-roy/_index.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No agency for this one. That ok?

bonnieAcameron
bonnieAcameron reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@bonnieAcameron bonnieAcameron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending the following: added small suggestions in the metadata, mostly typos, one missing agency.

bonnieAcameron and others added 6 commits February 19, 2025 13:04
@bonnieAcameron
remove blank authors d-e
da56e05
@nick-mon1
Fixed field name
62161c9
@nick-mon1
Removed broken tweet
ea5e832
@nick-mon1
Removed more broken tweets
896319e
@nick-mon1 @bonnieAcameron
Update content/authors/elham-tabassi/_index.md
a9af2d3 
Co-authored-by: Bonnie Cameron <96838068+bonnieAcameron@users.noreply.github.com>
@nick-mon1 @bonnieAcameron
Update content/authors/eric-mill/_index.md
dd32718 
Co-authored-by: Bonnie Cameron <96838068+bonnieAcameron@users.noreply.github.com>
@ToniBonittoGSA ToniBonittoGSA merged commit 1e26aeb into nl-remove-author-data-b-to-c Mar 4, 2025
2 checks passed
@ToniBonittoGSA ToniBonittoGSA deleted the nl-remove-author-data-d-to-e branch March 4, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonnieAcameron bonnieAcameron bonnieAcameron left review comments

@ToniBonittoGSA ToniBonittoGSA Awaiting requested review from ToniBonittoGSA

Assignees

@nick-mon1 nick-mon1

Labels
Content: Authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-mon1 @bonnieAcameron @ToniBonittoGSA