Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing input labels #8385

Merged
merged 9 commits into from
Mar 5, 2025
Merged

Adds missing input labels #8385

merged 9 commits into from
Mar 5, 2025

Conversation

nick-mon1
Copy link
Contributor

@nick-mon1 nick-mon1 commented Feb 14, 2025

Summary

Adds missing labels to input fields in markdown content.

Preview

Link to Preview

Solution

Before

  <input type="checkbox">Review the <a href="{{< ref "/guides/hcd/discovery-concepts/do-research.md" >}}">research section of the HCD Discovery Concepts Guide.</a>
  </input>
<br>

After

<label for="review">
  <input id="review" type="checkbox">Review the <a href="{{< ref "/guides/hcd/discovery-concepts/do-research.md" >}}">research section of the HCD Discovery Concepts Guide.</a>
  </input>
</label>
<br>

Copy link

🔍 Preview in Federalist

@nick-mon1 nick-mon1 assigned lyssaprince and unassigned nick-mon1 Feb 21, 2025
@nick-mon1 nick-mon1 requested review from bonnieAcameron and removed request for bonnieAcameron February 21, 2025 21:24
@nick-mon1
Copy link
Contributor Author

What I Tested

  • ran wave extension to see passing validations for label for each input
  • approved ✅

@nick-mon1 nick-mon1 requested review from ToniBonittoGSA and removed request for bonnieAcameron February 21, 2025 21:25
Copy link
Contributor

@ToniBonittoGSA ToniBonittoGSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch from implicit labels to explicit labels; details in JIRA 164

@ToniBonittoGSA ToniBonittoGSA merged commit 2829520 into main Mar 5, 2025
4 checks passed
@ToniBonittoGSA ToniBonittoGSA deleted the nl-add-missing-labels branch March 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants