use db, removed error logs, reformatted

Author: tejaswini-rb

src/app/api/partnerDetails/[userId]/route.test.ts

@@ -1,22 +1,13 @@
 import { testApiHandler } from "next-test-api-route-handler";
 import { authMock } from "@/test/authMock";
 import { dbMock } from "@/test/dbMock";
-import { expect, test, describe, jest } from "@jest/globals";
+import { expect, test, describe } from "@jest/globals";
 import { OrganizationType } from "@prisma/client";
-
-// mock @prisma/client so that new PrismaClient() -> dbMock for testing purposes
-jest.mock("@prisma/client", () => {
-  return {
-    PrismaClient: jest.fn().mockImplementation(() => dbMock),
-  };
-});
-
-// now that @prisma/client is mocked, we can the route code
 import * as appHandler from "./route";
 
 describe("POST /api/partnerDetails/[userId]", () => {
   beforeEach(() => {
-    jest.resetAllMocks();
+
   });
 
   //No Valid Session (401)
@@ -97,36 +88,6 @@ describe("POST /api/partnerDetails/[userId]", () => {
     });
   });
 
-  //Invalid User ID (400)
-  test("returns 404 when no PartnerDetails record exists", async () => {
-    authMock.mockReturnValueOnce({
-      user: { id: "1", type: "SUPER_ADMIN" },
-      expires: "",
-    });
-
-    // DB returns null
-    dbMock.partnerDetails.findUnique.mockResolvedValueOnce(null);
-
-    const formData = new FormData();
-    formData.append("numberOfPatients", "8");
-    formData.append("organizationType", "NON_PROFIT");
-
-    await testApiHandler({
-      appHandler,
-      params: { userId: "1" },
-      async test({ fetch }) {
-        const res = await fetch({
-          method: "POST",
-          body: formData,
-        });
-
-        expect(res.status).toBe(404);
-        const json = await res.json();
-        expect(json).toEqual({ message: "Partner details not found" });
-      },
-    });
-  });
-
   //Valid Request (200)
   test("updates PartnerDetails and returns 200 for a valid request", async () => {
     authMock.mockReturnValueOnce({

src/app/api/partnerDetails/[userId]/route.ts

@@ -1,12 +1,9 @@
-import { authenticationError, notFoundError, authorizationError, argumentError } from "@/util/responses";
+import { authenticationError, authorizationError, argumentError } from "@/util/responses";
 import { auth } from "@/auth";
 import { NextResponse, NextRequest } from "next/server";
 import { z } from "zod";
-import { zfd } from "zod-form-data"; // <-- Added import from zod-form-data
-import { PrismaClient } from "@prisma/client"; 
-
-// new Prisma Client
-const prisma = new PrismaClient();
+import { zfd } from "zod-form-data";
+import { db } from "@/db"; 
 
 // Zod schema
 const PartnerDetailsFormSchema = zfd.formData({
@@ -16,68 +13,52 @@ const PartnerDetailsFormSchema = zfd.formData({
 
 /**
  * Updates a user's partner details.
- * Accepts parameters as FormData.
- *
- * @param {NextRequest} req The incoming request object.
- * @param {Object} context The route parameters containing the user ID.
- *
- * @returns {NextResponse} 401 if request is not authenticated.
- * @returns {NextResponse} 403 if the session user is a PARTNER modifying another user's details.
- * @returns {NextResponse} 400 if the request body is invalid.
- * @returns {NextResponse} 404 if no PartnerDetails record is found.
- * @returns {NextResponse} 200 with the updated partner details.
+ * Parameters are passed as form data.
+ * 
+ * @param numberOfPatients The number of patients associated with the partner
+ * @param organizationType The type of the organization (NON_PROFIT, FOR_PROFIT, RELIGIOUS)
+ * @param userId The ID of the user whose partner details are being updated
+ * 
+ * @returns 401 if the request is not authenticated
+ * @returns 403 if a PARTNER user attempts to modify another user's details
+ * @returns 404 if no PartnerDetails record is found
+ * @returns 200 with the updated partner details
  */
 export async function POST(
   req: NextRequest,
   { params }: { params: Promise<{ userId: string }> }
 ) {
-  try {
+
     // authenticate the user session
     const session = await auth();
-    if (!session || !session.user) {
+    if (!session?.user) {
       return authenticationError("Session required");
     }
     const { user } = session;
 
     // await params and ensure params.userId exists
     const { userId } = await params;
     if (!userId) {
-      console.error("Missing user ID parameter in request");
       return argumentError("Missing user ID parameter");
     }
 
-    const userIdNumber = parseInt(userId, 10);
-    if (isNaN(userIdNumber)) {
-      console.error("Invalid user ID parameter");
-      return argumentError("Invalid user ID");
-    }
-
     // partner users can only modify their own details
-    if (user.type === "PARTNER" && String(user.id) !== String(userIdNumber)) {
+    if (user.type === "PARTNER" && user.id !== userId) {
       return authorizationError("You are not allowed to modify this record");
     }
 
     // parse FormData
     const formData = await req.formData();
     const parsedData = PartnerDetailsFormSchema.safeParse(formData);
     if (!parsedData.success) {
-      console.error("Invalid form data:", parsedData.error);
       return argumentError("Invalid form data");
     }
 
     const { numberOfPatients, organizationType } = parsedData.data;
 
-    // check if partnerDetails exists
-    const partnerDetails = await prisma.partnerDetails.findUnique({
-      where: { userId: userIdNumber },
-    });
-    if (!partnerDetails) {
-      console.error("Partner details not found for user ID:", userIdNumber);
-      return notFoundError("Partner details not found");
-    }
-
     // update PartnerDetails record
-    const updatedPartnerDetails = await prisma.partnerDetails.update({
+    const userIdNumber = Number(userId); //db schema accepts a number
+    const updatedPartnerDetails = await db.partnerDetails.update({
       where: { userId: userIdNumber },
       data: {
         numberOfPatients,
@@ -86,8 +67,4 @@ export async function POST(
     });
 
     return NextResponse.json(updatedPartnerDetails, { status: 200 });
-  } catch (error) {
-    console.error("Error updating PartnerDetails:", error);
-    return NextResponse.json({ message: "Internal Server Error" }, { status: 500 });
-  }
 }