Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove initialDecline functionality #1019

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

stephenerdelyi
Copy link
Collaborator

@stephenerdelyi stephenerdelyi commented Feb 18, 2025

Description of the Change

Removal of the "allow users to initially decline" option now that the plugin allows this update directly from the editor.

How to test the Change

Validate the "settings" area has been removed; validate the options are no longer available in the RSVP response block editor

Changelog Entry

Removed - InitialDecline functionality

Credits

@stephenerdelyi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@stephenerdelyi
Copy link
Collaborator Author

@mauteri , this is ready for your review. Pretty sure I got everything related to this deprecated option, but let me know if you see anything off! I had to set up a fresh install, so I wasn't able to test preexisting events if you could please test that specifically for me!

Copy link

Preview changes with Playground

You can preview the recent changes for PR#1019 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri
Copy link
Contributor

mauteri commented Feb 19, 2025

Thanks @stephenerdelyi! Merging!

@mauteri mauteri merged commit 637dbb3 into GatherPress:develop Feb 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants