Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 889 as it breaks Event Lists block. This code will need to be … #1020

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Feb 21, 2025

…revisited when we work on Query loop block and still work with upcoming/past archive pages.

Description of the Change

Reverts #889 due to sorting bugs.

Where possible, please also include:

  • verification steps to ensure your change has the desired effects and has not introduced any regressions
  • any benefits that will be realized
  • any alternative implementations or possible drawbacks that you considered
  • screenshots or screencasts
    -->

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @mauteri

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

…revisited when we work on Query loop block and still work with upcoming/past archive pages.
Copy link

Preview changes with Playground

You can preview the recent changes for PR#1020 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri marked this pull request as ready for review February 21, 2025 20:21
@mauteri mauteri merged commit 9fa1b14 into develop Feb 21, 2025
14 checks passed
@mauteri mauteri deleted the revert-889 branch February 21, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant