Skip to content

Commit 364beef

Browse files
committed
manually fix remaining eslint errors
1 parent 7b35b9a commit 364beef

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

.eslintrc.js

+3
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ module.exports = {
7373
// Test files:
7474
files: ['tests/**/*-test.{js,ts}'],
7575
extends: ['plugin:qunit/recommended'],
76+
rules: {
77+
'qunit/require-expect': 'warn',
78+
},
7679
},
7780
],
7881
};

tests/integration/components/bs-dropdown-test.js

+2
Original file line numberDiff line numberDiff line change
@@ -569,13 +569,15 @@ module('Integration | Component | bs-dropdown', function (hooks) {
569569
}
570570

571571
module('in place', function (hooks) {
572+
// eslint-disable-next-line qunit/no-hooks-from-ancestor-modules
572573
hooks.beforeEach(function () {
573574
this.renderInPlace = true;
574575
});
575576
keyboardTest();
576577
});
577578

578579
module('in wormhole', function () {
580+
// eslint-disable-next-line qunit/no-hooks-from-ancestor-modules
579581
hooks.beforeEach(function () {
580582
this.renderInPlace = false;
581583
});

tests/integration/components/bs-modal/footer-test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module('Integration | Component | bs-modal/footer', function (hooks) {
1515
assert.dom('.modal-footer').exists({ count: 1 }, 'Modal footer exists.');
1616
assert.dom('.modal-footer button').exists({ count: 1 }, 'Modal has button.');
1717
assert.dom('.modal-footer button').hasClass('btn-primary', 'Button is a primary button.');
18-
assert.ok(
18+
assert.strictEqual(
1919
this.element.querySelector('.modal-footer button').getAttribute('type'),
2020
'button',
2121
'Submit button is of type submit.'
@@ -28,14 +28,14 @@ module('Integration | Component | bs-modal/footer', function (hooks) {
2828

2929
assert.dom('.modal-footer button').exists({ count: 2 }, 'Modal footer has two button.');
3030
assert.dom('.modal-footer button:first-child').hasClass(defaultButtonClass(), 'Close button is a default button.');
31-
assert.ok(
31+
assert.strictEqual(
3232
this.element.querySelector('.modal-footer button:first-child').getAttribute('type'),
3333
'button',
3434
'Submit button is of type submit.'
3535
);
3636
assert.dom('.modal-footer button:first-child').hasText('close', 'Close button title is correct.');
3737
assert.dom('.modal-footer button:last-child').hasClass('btn-primary', 'Submit button is a primary button.');
38-
assert.ok(
38+
assert.strictEqual(
3939
this.element.querySelector('.modal-footer button:last-child').getAttribute('type'),
4040
'submit',
4141
'Submit button is of type submit.'

tests/integration/components/bs-tooltip-test.js

-13
Original file line numberDiff line numberDiff line change
@@ -342,19 +342,6 @@ module('Integration | Component | bs-tooltip', function (hooks) {
342342
assert.ok(isVisible(this.element.querySelector('.tooltip')), '200ms: tooltip is faded in');
343343
});
344344

345-
test('should not show tooltip if leave event occurs before delay expires', async function (assert) {
346-
await render(hbs`<div id="target"><BsTooltip @title="Dummy" @delay={{150}} /></div>`);
347-
348-
triggerEvent('#target', 'mouseenter');
349-
350-
await delay(100);
351-
assert.notOk(isVisible(this.element.querySelector('.tooltip')), '100ms: tooltip not faded in');
352-
triggerEvent('#target', 'mouseleave');
353-
354-
await delay(100);
355-
assert.notOk(isVisible(this.element.querySelector('.tooltip')), '200ms: tooltip not faded in');
356-
});
357-
358345
test('should not hide tooltip if leave event occurs and enter event occurs within the hide delay', async function (assert) {
359346
await render(hbs`<div id="target"><BsTooltip @title="Dummy" @delayShow={{0}} @delayHide={{150}} /></div>`);
360347
triggerEvent('#target', 'mouseenter');

0 commit comments

Comments
 (0)