Skip to content

Commit faf17fd

Browse files
committed
fix bug exposed by eslint fix
1 parent 364beef commit faf17fd

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

addon/components/bs-modal/footer.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
{{else}}
66
{{#if @submitTitle}}
77
<Button @onClick={{@onClose}}>{{bs-default @closeTitle "Ok"}}</Button>
8-
<Button @type={{bs-default @submitButtonType "primary"}} onClick={{@onSubmit}} disabled={{bs-default @submitDisabled false}}>{{@submitTitle}}</Button>
8+
<Button @type={{bs-default @submitButtonType "primary"}} @buttonType={{@submitButtonType}} onClick={{@onSubmit}} disabled={{bs-default @submitDisabled false}}>{{@submitTitle}}</Button>
99
{{else}}
1010
<Button @type="primary" @onClick={{@onClose}}>{{bs-default @closeTitle "Ok"}}</Button>
1111
{{/if}}

tests/integration/components/bs-modal/footer-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module('Integration | Component | bs-modal/footer', function (hooks) {
1818
assert.strictEqual(
1919
this.element.querySelector('.modal-footer button').getAttribute('type'),
2020
'button',
21-
'Submit button is of type submit.'
21+
'Submit button is of type button.'
2222
);
2323
assert.dom('.modal-footer button').hasText('close', 'Button title is correct.');
2424
});
@@ -31,7 +31,7 @@ module('Integration | Component | bs-modal/footer', function (hooks) {
3131
assert.strictEqual(
3232
this.element.querySelector('.modal-footer button:first-child').getAttribute('type'),
3333
'button',
34-
'Submit button is of type submit.'
34+
'Close button is of type button.'
3535
);
3636
assert.dom('.modal-footer button:first-child').hasText('close', 'Close button title is correct.');
3737
assert.dom('.modal-footer button:last-child').hasClass('btn-primary', 'Submit button is a primary button.');

0 commit comments

Comments
 (0)