Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for ember 4.12 #2

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Update for ember 4.12 #2

wants to merge 22 commits into from

Conversation

Gaurav0
Copy link
Owner

@Gaurav0 Gaurav0 commented Nov 6, 2024

This updates my fork for use in Ember 4.12.

@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch 2 times, most recently from 074f774 to 3f6a60b Compare November 6, 2024 12:15
@Gaurav0 Gaurav0 marked this pull request as ready for review November 6, 2024 12:15
@Gaurav0 Gaurav0 marked this pull request as draft November 6, 2024 12:16
@Gaurav0 Gaurav0 changed the base branch from v4 to master November 6, 2024 12:17
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch from 3f6a60b to e7b5b28 Compare November 6, 2024 12:46
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch from e7b5b28 to c7385c1 Compare November 6, 2024 12:48
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch 2 times, most recently from 268afff to faf17fd Compare November 6, 2024 15:14
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch from faf17fd to afbae73 Compare November 6, 2024 15:36
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch from ec6310f to e74ac09 Compare November 8, 2024 14:06
do not test ember 4.12 in CI due to bug in @ember/string deprecation
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch from a3f9d99 to 4f2213e Compare November 8, 2024 14:57
Gaurav0 and others added 2 commits November 8, 2024 11:20
…mption error in Ember canary (ember-bootstrap#2027)

* Refactor bs-alert to remove @localcopy

The `@localCopy` decorate caused issues on Ember canary builds.
By refactoring this component to use pure Ember reactivity we can get
rid of the decorator.

* Allow re-enabling of alert using property after hiding it by clicking
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch from bde6cef to fe95c91 Compare November 8, 2024 16:20
@Gaurav0 Gaurav0 force-pushed the update_for_ember_4.12 branch from e220f31 to 83affa3 Compare November 9, 2024 10:42
@Gaurav0
Copy link
Owner Author

Gaurav0 commented Nov 10, 2024

Tests failing on Ember 5.12+, but passing in Ember 4.4, 4.8, 5.4 and 5.8

Tests failing in Ember 4.12 due to bug in the @ember/string deprecation: emberjs/ember.js#20377

@Gaurav0 Gaurav0 marked this pull request as ready for review November 10, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants