Migrate to Vite #352
Merged
Migrate to Vite #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibautBremand
added
the
dependencies
ThibautBremand
force-pushed
the
feat/migrate-to-vite
branch
3 times, most recently
from
46b388f to
5d92a53
Compare
Upgrade major dependencies
ThibautBremand
force-pushed
the
feat/migrate-to-vite
branch
2 times, most recently
from
a60f840 to
513b806
Compare
packages/extension/src/components/organisms/TransactionListing/format.util.ts
Show resolved
Hide resolved
ThibautBremand
force-pushed
the
feat/migrate-to-vite
branch
from
c463dd8 to
cfed13e
Compare
| "stream-browserify": "^3.0.0", | ||
| "web-vitals": "^3.5.1", | ||
| "xrpl": "^3.0.0", | ||
| "xrpl-accountlib": "^3.2.9" | ||
| }, | ||
| "devDependencies": { | ||
| "@gemwallet/constants": "*", | ||
| "@gemwallet/eslint-config": "*", |
There was a problem hiding this comment.
You are pulling our eslint configuration, though we can see in the dev dependencies that you are using the dependencies from vite.js as you require another version of eslint.
We have two solutions here:
- We use the configuration from vite.js for the linter on the extension and the package @gemwallet/eslint-config for the API
- We update our configuration within @gemwallet/eslint-config to match vite and override it, and we make use of it within the extension.
We can also do this in another MR to don't add more change as this is not blocker.
What do you think?
FlorianBouron
force-pushed
the
feat/migrate-to-vite
branch
from
4dd6d75 to
6adb39f
Compare
FlorianBouron
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.