Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for "umm alqura" calendar #12

Open
mohamad-dekmak opened this issue Nov 14, 2018 · 0 comments
Open

No support for "umm alqura" calendar #12

mohamad-dekmak opened this issue Nov 14, 2018 · 0 comments

Comments

@mohamad-dekmak
Copy link

Hello,
I tried to use this library but I found that there are no support for the Hijri Calendar "umm alqura".
This is an example:
$date_gregorian = \GeniusTS\HijriDate\Hijri::convertToGregorian(01, 04, 1440);
it should return the Gregorian date "2018-12-08" based on the official Hijri calendar (http://www.ummulqura.org.sa). But in fact, it returns "2018-12-09".
Note that, all days in the month "03" are valid but starting from the month "04" it will return wrong date. It seems that, it counts 30 days in the month "03" which is wrong as it is 29 days.

@mohamad-dekmak mohamad-dekmak changed the title No support for um malqura calendar No support for "umm alqura" calendar Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant