Skip to content

Commit

Permalink
Add 8.4 to testing matrix (#18)
Browse files Browse the repository at this point in the history
  • Loading branch information
dafeder authored Feb 18, 2025
1 parent 54b12e9 commit 0a0a787
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,5 +176,5 @@ workflows:
- matrix-conditions:
matrix:
parameters:
version: ["7.4", "8.0", "8.1", "8.2", "8.3"]
version: ["7.4", "8.0", "8.1", "8.2", "8.3", "8.4"]
install-flags: ["", "--prefer-lowest"]
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
"ext-json": "*"
},
"require-dev": {
"phpunit/phpunit": "^9.6",
"phpunit/phpunit": "^9.6.22",
"rector/rector": "^0.15.17",
"squizlabs/php_codesniffer": "^3.7",
"symfony/phpunit-bridge": "^7.0"
"symfony/phpunit-bridge": "^7.2"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion src/Mock/Storage/JsonObjectMemory.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function retrieveAll(): array
return $results;
}

public function store($data, string $id = null): string
public function store($data, ?string $id = null): string
{
$this->validate($data);
return parent::store($data, $id);
Expand Down
2 changes: 1 addition & 1 deletion src/Mock/Storage/Memory.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function retrieveAll(): array
return $this->storage;
}

public function store($data, string $id = null): string
public function store($data, ?string $id = null): string
{
if (!isset($id)) {
throw new \Exception("An id is required to store the data.");
Expand Down
2 changes: 1 addition & 1 deletion src/StorerInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ interface StorerInterface
* @throws \Exception
* Issues storing the data.
*/
public function store($data, string $id = null): string;
public function store($data, ?string $id = null): string;
}

0 comments on commit 0a0a787

Please sign in to comment.