Adds MimeType to Attachment struct #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's present in the raw JSON, just not on this field
CharlesWinter
requested review from
totalimmersion and
JimmyPettersson85
as code owners
|
@totalimmersion @JimmyPettersson85 Hello! 👋 is there something more I have to do to get this reviewed and hopefully approved? I couldn't see anything obvious in the PR guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's present in the raw JSON, just not on the actual type.
Submit a pull request
CLA
Description of the pull request
Adds the missing MimeType field to the Attachments struct. It's present in the returned JSON from the webhook.