chore: add retry count and wait time to constants

Author: isekovanic

src/channel_manager.ts

@@ -22,6 +22,10 @@ import {
   waitSeconds,
 } from './utils';
 import { generateUUIDv4 } from './utils';
+import {
+  DEFAULT_QUERY_CHANNELS_RETRY_COUNT,
+  DEFAULT_QUERY_CHANNELS_SECONDS_BETWEEN_RETRIES,
+} from './constants';
 
 export type ChannelManagerPagination = {
   filters: ChannelFilters;
@@ -291,8 +295,7 @@ export class ChannelManager {
         { method: 'upsertCidsForQuery' },
       );
     } catch (err) {
-      // TODO: Extract this as a constant
-      if (retryCount >= 2) {
+      if (retryCount >= DEFAULT_QUERY_CHANNELS_RETRY_COUNT) {
         console.warn(err);
 
         const wrappedError = new Error(
@@ -303,8 +306,7 @@ export class ChannelManager {
         return;
       }
 
-      // TODO: Maybe make this configurable ?
-      await waitSeconds(2);
+      await waitSeconds(DEFAULT_QUERY_CHANNELS_SECONDS_BETWEEN_RETRIES);
 
       return this.queryChannelsRequest(payload, retryCount + 1);
     }

src/constants.ts

@@ -26,5 +26,6 @@ export const RESERVED_UPDATED_MESSAGE_FIELDS = {
   __html: true,
   user: true,
 } as const;
-
 export const LOCAL_MESSAGE_FIELDS = { error: true } as const;
+export const DEFAULT_QUERY_CHANNELS_RETRY_COUNT = 3;
+export const DEFAULT_QUERY_CHANNELS_SECONDS_BETWEEN_RETRIES = 1;

test/unit/channel_manager.test.ts

@@ -17,6 +17,7 @@ import * as utils from '../../src/utils';
 
 import { describe, beforeEach, afterEach, expect, it, vi, MockInstance } from 'vitest';
 import { MockOfflineDB } from './offline-support/MockOfflineDB';
+import { DEFAULT_QUERY_CHANNELS_RETRY_COUNT } from '../../src/constants';
 
 describe('ChannelManager', () => {
   let client: StreamChat;
@@ -740,8 +741,12 @@ describe('ChannelManager', () => {
 
           const { channels, initialized } = channelManager.state.getLatestValue();
 
-          expect(clientQueryChannelsStub.callCount).to.equal(3); // initial + 2 retries
-          expect(waitSecondsSpy).toHaveBeenCalledTimes(2);
+          expect(clientQueryChannelsStub.callCount).to.equal(
+            DEFAULT_QUERY_CHANNELS_RETRY_COUNT + 1,
+          ); // // initial + however many retried are configured
+          expect(waitSecondsSpy).toHaveBeenCalledTimes(
+            DEFAULT_QUERY_CHANNELS_RETRY_COUNT,
+          );
           expect(stateChangeSpy.callCount).to.equal(1);
           expect(stateChangeSpy.args[0][0]).to.deep.equal({
             error: new Error(