refactor: general code cleanup (Threads/Polls/MessageComposer) #1522
+287
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.97 kB (+0.52%) Total Size: 381 kB
|
arnautov-anton
commented
May 4, 2025
arnautov-anton
force-pushed
the
refactor/general-code-cleanup
branch
2 times, most recently
from
2ee2795 to
f3f380d
Compare
arnautov-anton
force-pushed
the
refactor/general-code-cleanup
branch
2 times, most recently
from
b6515cb to
18d62f3
Compare
arnautov-anton
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
MartinCupela and
myandrienko
as code owners
MartinCupela
reviewed
May 9, 2025
MartinCupela
reviewed
May 9, 2025
arnautov-anton
force-pushed
the
refactor/general-code-cleanup
branch
2 times, most recently
from
4101a39 to
d1a8553
Compare
Co-authored-by: Martin Cupela <martin.cupela@gmail.com>
arnautov-anton
force-pushed
the
refactor/general-code-cleanup
branch
from
d1a8553 to
66c466b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?
Introduces private
WithSubscriptionsabstract class as a base for all of our new entities.