fix: add optional raw queryChannels api response #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isekovanic
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
arnautov-anton,
MartinCupela and
myandrienko
as code owners
|
Size Change: +248 B (+0.07%) Total Size: 378 kB
|
github-actions bot
pushed a commit
that referenced
this pull request
May 12, 2025
## [9.1.1](v9.1.0...v9.1.1) (2025-05-12) ### Bug Fixes * add optional raw queryChannels api response ([#1530](#1530)) ([23eebf0](23eebf0))
|
🎉 This PR is included in version 9.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
This PR allows
client.queryChannelsto optionally return the raw response and not run hydration at all (and subsequently not provide an array ofChannelinstances).It is meant to be used generally server-side so that integrators can have access to other fields not available in a
Channelinstance. It should resolve this Zendesk ticket.We can probably keep it the same api if we use discriminated unions, but I feel like it'd complicate things further for no good reason. Keeping the apis separate made sense to me.
Changelog