Skip to content

feat: add toJSON to ErrorFromResponse class #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

arnautov-anton
Copy link
Contributor

@arnautov-anton arnautov-anton commented May 14, 2025

Description of the changes, What, Why and How?

Vitest serializes errors and our error instance keeps a ton of data (from Axios) which - when serialized - pollutes test logs with unreadable messages (see GetStream/chat#8211 QA runs for "before").

(it's way longer, see scrollbar)

after:
image

This needs to be copied over to video SDK as well.

Copy link
Contributor

github-actions bot commented May 14, 2025

Size Change: +747 B (+0.2%)

Total Size: 379 kB

Filename Size Change
dist/cjs/index.browser.cjs 107 kB +249 B (+0.23%)
dist/cjs/index.node.cjs 151 kB +248 B (+0.16%)
dist/esm/index.js 120 kB +250 B (+0.21%)

compressed-size-action

@arnautov-anton arnautov-anton force-pushed the fix/reduce-error-from-response-size branch from 325d81c to 14fe5be Compare May 14, 2025 14:59
@arnautov-anton arnautov-anton force-pushed the fix/reduce-error-from-response-size branch from 14fe5be to 5fff918 Compare May 14, 2025 15:01
@arnautov-anton arnautov-anton merged commit 8f6948f into master May 15, 2025
13 of 16 checks passed
@arnautov-anton arnautov-anton deleted the fix/reduce-error-from-response-size branch May 15, 2025 08:51
github-actions bot pushed a commit that referenced this pull request May 22, 2025
## [9.2.0-offline-support-beta.1](v9.1.1...v9.2.0-offline-support-beta.1) (2025-05-22)

### Bug Fixes

* add new poll option only when all of the current options are filled ([#1532](#1532)) ([86cd646](86cd646))
* adjust MessageBase.type to MessageLabel ([55a988e](55a988e))
* adjust TextComposer middleware to correctly handle triggers in combination ([6922024](6922024))
* allow to compose non-empty message from draft without local edits ([#1533](#1533)) ([a704fc3](a704fc3))
* channel.truncated edge cases and missing functionality ([c7887d6](c7887d6))
* check for commands trigger and not hardcoded string values ([20eb30d](20eb30d))
* check for composition type before message type when storing edited message ([2febce6](2febce6))
* check for message in undefined message draft ([0b1b773](0b1b773))
* commands trigger ([598f8cb](598f8cb))
* create draft even though some attachments are uploading ([dc28f61](dc28f61))
* create draft with link preview from link preview data ([324e4c4](324e4c4))
* do not add fields to LocalMessage object ([c34e365](c34e365))
* do not check for the first argument in commands middleware onChange handler ([9d136d0](9d136d0))
* do not perform link preview enrichment if server-side enrichment is disabled ([4ff6380](4ff6380))
* do not pick any other occurances of / in the text for commands ([04d927f](04d927f))
* get link preview data correctly on composition ([448b6ac](448b6ac))
* handle error thrown in withCancellation pipeline of TextComposerComposerMiddlewareExecutor ([a3529c1](a3529c1))
* ignore own_capability errors for pending tasks ([d614dcb](d614dcb))
* improve apis ([4f898b0](4f898b0))
* initiate composer text from the default value with cursor at the end ([d4a095d](d4a095d))
* local message error type ([9bc7935](9bc7935))
* make command search case-insensitive and reset custom command search source before use ([f523b90](f523b90))
* make getStateBeforeFirstQuery for MentionsSearchSource public and middleware options partial ([785c6f0](785c6f0))
* make sure command trigger is reflected only if at the beginning of text ([4a5a958](4a5a958))
* make updated message payload to carry undefined mentioned users if empty ([10b5bbc](10b5bbc))
* merge conflicts ([ccef0b1](ccef0b1))
* more merge conflicts ([f41cd88](f41cd88))
* move db apis to main class ([c4bb2ab](c4bb2ab))
* pending tasks type ([deec2f1](deec2f1))
* prevent empty poll options and questions in composition ([#1541](#1541)) ([b2e2702](b2e2702))
* queries with channel guard and member count ([ad8197b](ad8197b))
* race condition with query scheduling ([34e6af2](34e6af2))
* remove storing draft in channel state ([b382912](b382912))
* remove tokenization payload from user suggestion on select ([d0e091c](d0e091c))
* return selection from insertItemWithTrigger instead of selections ([e9881ec](e9881ec))
* schedule only on successful sync ([e9428d5](e9428d5))
* set MessageComposer editedMessage on each initState call ([69d78dd](69d78dd))
* solve weird merging issue ([abd4049](abd4049))
* types ([78baf2e](78baf2e))
* update last sync timestamp when closing connection ([ba4cf09](ba4cf09))
* update pending tasks ([ee06fc3](ee06fc3))
* update the composer text with default value if config changes ([cb37c34](cb37c34))
* use event member properly ([007ad1d](007ad1d))

### Features

* [MOD-513]: Soft/Hard Delete Messages on Ban ([#1538](#1538)) ([5fff918](5fff918))
* add api for fetching app settings ([6446c4f](6446c4f))
* add channel manager retry policy ([dc01d4d](dc01d4d))
* add channel.truncated handling ([c566c51](c566c51))
* add configurations to AttachmentManager, LinkPreviewsManager, TextComposer ([9e1ef60](9e1ef60))
* add custom data message composer ([0c2d04d](0c2d04d))
* add default middleware in TextComposerMiddlewareExecutor constructor ([92e585a](92e585a))
* add delete channel api ([5ea33e4](5ea33e4))
* add draft management to message composer ([a7c98f6](a7c98f6))
* add field origin to Notification ([b860910](b860910))
* add MentionsSearchSource with support for discarding obsolete middleware results ([699ff25](699ff25))
* add message composition with middleware to MessageComposer ([12d809a](12d809a))
* add message removal functionality ([676661e](676661e))
* add MessageComposer ([99dfcfc](99dfcfc))
* add NotificationManager.ts ([82afe07](82afe07))
* add NotificationManager.ts ([79cd303](79cd303))
* add offline api for querying reactions ([4deedf8](4deedf8))
* add optimistic reaction removal capability to llc ([6c1cb2a](6c1cb2a))
* add pending tasks for sending messages ([640a15d](640a15d))
* add poll db updates to llc ([109fcd2](109fcd2))
* add PollComposer ([880a7af](880a7af))
* add removing reactions and fix sending reactions ([e509932](e509932))
* add sending reactions support ([4c7812e](4c7812e))
* add sync manager implementation ([ab43f54](ab43f54))
* add text length validation on change and centralize configuration ([cd89372](cd89372))
* add toJSON to ErrorFromResponse class ([#1540](#1540)) ([8f6948f](8f6948f)), closes [GetStream/chat#8211](https://github.com/GetStream/chat/issues/8211)
* alias the FormatMessageResponse to LocalMessage ([047cc33](047cc33))
* allow for custom non-message data storage in MessageComposer ([d87590e](d87590e))
* enable send reaction state updates from llc ([ea47d2b](ea47d2b))
* error handling of db query writes ([62512a2](62512a2))
* export middleware module from stream-chat ([768e697](768e697))
* init textComposer selection from the provided text ([fac5313](fac5313))
* initial pass at queryChannels and related endpoints ([262520c](262520c))
* initiate composer text from the default value ([6ed186f](6ed186f))
* introduce LocalMessage type and use it in the state ([6619304](6619304))
* keep draft id in the message composer state ([f50a9d0](f50a9d0))
* **link-previews:** strengthen URL hostname validation ([3d99bf9](3d99bf9))
* make AttachmentManager upload RN files ([9eff316](9eff316))
* message deletes ([6048498](6048498))
* move event handling to single abstraction ([08ce31c](08ce31c))
* move member and message updated events to llc ([d356bbf](d356bbf))
* move more channel events to llc ([0a54969](0a54969))
* move notification events to the llc too ([6e3f18a](6e3f18a))
* new message handling and query guards ([0b5ed66](0b5ed66))
* read and unread events ([588791b](588791b))
* set custom upload fn, uploads in progress count toward available slots, preserve original attachment id ([11ecf89](11ecf89))
* support message drafts for channels ([e3a1cb8](e3a1cb8))
* sync api and synced reactins and ws events ([02de287](02de287))

### Refactors

* add ability to signal middleware result to be discarded ([7e227e7](7e227e7))
* add MessageDraftComposerMiddlewareValue type ([d658d8b](d658d8b))
* add MessageDraftComposerMiddlewareValue type ([74237d5](74237d5))
* add NotificationManager state getters and use single object arguments ([054aa7b](054aa7b))
* adjust updatedMessage method to server-side use and LocalMessage revert ([e76c8b9](e76c8b9))
* change Notification.origin to type NotificationOrigin ([fd3d758](fd3d758))
* keep central configuration in MessageComposer ([26659f3](26659f3))
* list all the local members at once with local mentions search ([ee51690](ee51690))
* make LocalMessage.error optional ([f2a9b86](f2a9b86))
* provide default messageComposer config param ([cdf85bc](cdf85bc))
* remove console.log ([f95c5f4](f95c5f4))
* remove LinkPreview class in favor of plain objects ([cfb6799](cfb6799))
* remove MessageComposer setter on Thread and Channel ([e872576](e872576))
* rename isRNFile to isFileReference ([abe6fac](abe6fac))
* rename message composer middleware ids ([5dd0f20](5dd0f20))
* rename MessageComposer middlewareManager to compositionMiddlewareManager ([63bcebd](63bcebd))
* rename RNFile to FileReference ([70708da](70708da))
* rename tokenizedDisplayName attribute ([3f85887](3f85887))
@stream-ci-bot
Copy link

🎉 This PR is included in version 9.2.0-offline-support-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants