fix(sample-app): for the loading status which did not return to false when the list of attachments or pinned messages was empty #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of attachments or pinned messages was empty
sn4f
changed the title
santhoshvai
approved these changes
Apr 1, 2024
santhoshvai
changed the title
|
🎉 This PR is included in version 5.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The goal of this change is to fix a bug in the usePaginatedAttachments and usePaginatedPinnedMessages hooks. This bug caused the loading state to not be reset to false for empty lists. As a result, the empty list indicator could not be displayed.
🛠 Implementation details
The change consists of adding the following code to both hooks:
setLoading(false)🧪 Testing