Skip to content

feat: Implement SDK Size analysis on CI #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Aug 20, 2024
Merged

feat: Implement SDK Size analysis on CI #2612

merged 68 commits into from
Aug 20, 2024

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Aug 8, 2024 •
edited
Loading

🔗 Issue Links

https://stream-io.atlassian.net/browse/PBE-5407

🎯 Goal

Show SDKs' size update on PR

📺 Showcase

Screenshot 2024-08-19 at 5 48 47 PM

🧪 Test

cd examples/SampleApp
bundle install
bundle exec fastlane show_frameworks_sizes

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple added the CI/CD CI/CD related build tasks label Aug 8, 2024
@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Aug 9, 2024 •
edited
Loading

SDK Size

title develop branch diff status
js_bundle_size 439 KB 438 KB -555 B 🚀

@testableapple testableapple requested review from santhoshvai and khushal87 and removed request for santhoshvai August 19, 2024 17:52
santhoshvai
santhoshvai reviewed Aug 20, 2024
View reviewed changes
testableapple
testableapple commented Aug 20, 2024
View reviewed changes
@testableapple testableapple merged commit 8812be4 into develop Aug 20, 2024
5 checks passed
@testableapple testableapple deleted the ci/show-sdk-size branch August 20, 2024 10:10
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshvai santhoshvai santhoshvai approved these changes

@khushal87 khushal87 khushal87 approved these changes

Assignees
No one assigned
Labels
CI/CD CI/CD related build tasks released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@testableapple @Stream-SDK-Bot @stream-ci-bot @santhoshvai @khushal87