Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audio component recursive loading for expo #3038

Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix: audio component recursive loading for expo #3038

merged 1 commit into from
Mar 27, 2025

Conversation

isekovanic
Copy link
Contributor

@isekovanic isekovanic commented Mar 26, 2025 •
edited
Loading

🎯 Goal

Fixes this Github issue.

Tons of credit to @thib92 for the initial fix !

Linear issue: https://linear.app/stream/issue/RN-173/[]-voice-message-playback-runs-an-infinite-useeffect-loop-in-v6

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@isekovanic isekovanic mentioned this pull request Mar 26, 2025
Closed
6 tasks
@Stream-SDK-Bot
Copy link
Contributor

SDK Size

title develop branch diff status
js_bundle_size 467 KB 467 KB +56 B 🟢

@isekovanic isekovanic merged commit 57f67e7 into develop Mar 27, 2025
6 checks passed
@isekovanic isekovanic deleted the fix/audio-component-infinite-action branch March 27, 2025 08:52
@github-actions github-actions bot mentioned this pull request Mar 27, 2025
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 6.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverlaz oliverlaz oliverlaz approved these changes

@khushal87 khushal87 khushal87 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛] 🔥 Voice message playback runs an infinite useEffect loop in v6
5 participants
@isekovanic @Stream-SDK-Bot @stream-ci-bot @oliverlaz @khushal87