Skip to content

Commit 1ff586a

Browse files
authored
fix: suggestion onClickHandler type (#2343)
Noticed that an example in our docs is broken. Turns out, we provided wrong typings for the `onClickHandler` in `ChatAutoComplete`. The reason it passed type checks before is that the suggestion list component is in a JSX file (not TSX). I'm not going to switch it TSX right now, but the types are worth fixing quickly. Also removed outdated demos that will break because of this change.
1 parent 87bf84c commit 1ff586a

File tree

332 files changed

+26
-38819
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

332 files changed

+26
-38819
lines changed

β€Ždocusaurus/docs/React/guides/customization/suggestion-list.mdx

+4-2
Original file line numberDiff line numberDiff line change
@@ -126,14 +126,15 @@ const SuggestionItem = React.forwardRef(
126126
const { item, onClickHandler, onSelectHandler, selected } = props;
127127

128128
const selectItem = () => onSelectHandler(item);
129+
const clickItem = (event: MouseEvent<HTMLDivElement>) => onClickHandler(event, item);
129130

130131
const itemName = isEmojiOrMention(item) ? item.name || item.id : item.name;
131132
const displayText = isEmoji(item) ? `${item.native} - ${itemName}` : itemName;
132133

133134
return (
134135
<div
135136
className={`suggestion-item ${selected ? 'selected' : ''}`}
136-
onClick={onClickHandler}
137+
onClick={clickItem}
137138
onMouseEnter={selectItem}
138139
ref={ref}
139140
role='button'
@@ -211,14 +212,15 @@ const SuggestionItem = React.forwardRef(
211212
const { item, onClickHandler, onSelectHandler, selected } = props;
212213

213214
const selectItem = () => onSelectHandler(item);
215+
const clickItem = (event: MouseEvent<HTMLDivElement>) => onClickHandler(event, item);
214216

215217
const itemName = isEmojiOrMention(item) ? item.name || item.id : item.name;
216218
const displayText = isEmoji(item) ? `${item.native} - ${itemName}` : itemName;
217219

218220
return (
219221
<div
220222
className={`suggestion-item ${selected ? 'selected' : ''}`}
221-
onClick={onClickHandler}
223+
onClick={clickItem}
222224
onMouseEnter={selectItem}
223225
ref={ref}
224226
role='button'

β€Žexamples/website-demos/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
The demos have a new home. Check out the [website-react-examples](https://github.com/GetStream/website-react-examples) repository for the latest React sample apps.

β€Žexamples/website-demos/social-messaging/.gitignore

-23
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
This demo [has a new home](https://github.com/GetStream/website-react-examples/tree/master/social-messenger-ts).
2+
3+
Check out the [website-react-examples](https://github.com/GetStream/website-react-examples) repository for the latest React sample apps.

β€Žexamples/website-demos/social-messaging/package.json

-40
This file was deleted.

β€Žexamples/website-demos/social-messaging/public/index.html

-36
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/App.tsx

-23
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/ActionsEllipse.tsx

-24
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/AddChat.tsx

-25
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/ArrowLeft.tsx

-26
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/Attach.tsx

-20
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/BlankAvatar.tsx

-28
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/Chats.tsx

-17
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/ClearSearch.tsx

-22
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/CloseSnackbar.tsx

-23
This file was deleted.

β€Žexamples/website-demos/social-messaging/src/assets/CloseX.tsx

-11
This file was deleted.

0 commit comments

Comments
Β (0)