You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: workflow cleanup and release process adjustments (#2663)
### 🎯 Goal
- [x] created a dedicated action for setting up Node environment with
own cacheing mechanism (like in `stream-chat`), this action is now used
by all existing workflows
- [x] adjusted `pr-title.yml` to use existing `@commitlint/cli` package
(used in `commit-msg` Husky hook)
- [x] adjusted how the next version is acquired - [npm
publish](https://docs.npmjs.com/cli/v10/using-npm/scripts#npm-publish)
runs `prepack` hook during which the next version is already defined
within `package.json#version` so we can grab it from there when running
build which now runs only once during the release process
- [x] changed `__STREAM_CHAT_REACT_VERSION__` to
`process.env.STREAM_CHAT_REACT_VERSION` which can be populated through
ESBuild's `define` property, dropping `esbuild-plugin-replace`,
`bundle-esm.mjs` uses this new string to replace too
- [x] removed `docs_release` from the `release.yml` (not needed anymore)
- [x] upgraded `actions/{cache,checkout,setup-node}` to v4
- [x] remove `docusaurus` and `docs` folders
Copy file name to clipboardexpand all lines: CONTRIBUTING.md
+19-10
Original file line number
Diff line number
Diff line change
@@ -8,41 +8,46 @@ As a contributor, here are the guidelines we would like you to follow:
8
8
-[Submission Guidelines](#submission-guidelines)
9
9
-[Signing the CLA](#contributor-licence-agreement)
10
10
11
-
12
11
## <aname="asking-questions"></a>Are you looking for answers?
12
+
13
13
There are many ways you can get your questions answered. It can be hard to decide, where to begin if you are just starting out. We suggest you take a look at the resources in the following order:
14
14
15
15
### 1. Stream chat API documentation
16
-
Package `stream-chat-react` has a peer dependency [stream-chat-js](https://github.com/GetStream/stream-chat-js) - a client library for interacting with the Stream Chat API (see the [API docs](https://getstream.io/chat/docs/javascript/?language=javascript)).
16
+
17
+
Package `stream-chat-react` has a peer dependency [stream-chat-js](https://github.com/GetStream/stream-chat-js) - a client library for interacting with the Stream Chat API (see the [API docs](https://getstream.io/chat/docs/javascript/?language=javascript)).
17
18
18
19
### 2. Documentation for stream-chat-react
20
+
19
21
The [stream-chat-react](https://getstream.io/chat/docs/sdk/react/) documentation is held separately from the Stream Chat API docs. Besides documenting the component API, it provides examples of their use in various scenarios.
20
22
21
23
### 3. Read the source code
24
+
22
25
When you plan on contributing to the repository try to get acquainted with the existing code base. The best way to learn :)
23
26
24
27
### 4. Take a look at our tutorials
25
28
26
-
27
29
### Get help from our Customer Success team
28
-
If what you are looking for is technical support embedding Stream in your application, we suggest emailing our Customer Success team at support@getstream.io with your application key and the SDK versions you're using. The Issue section of this GitHub repo is now reserved only for bug reports, feature improvements and suggestions.
29
30
31
+
If what you are looking for is technical support embedding Stream in your application, we suggest emailing our Customer Success team at support@getstream.io with your application key and the SDK versions you're using. The Issue section of this GitHub repo is now reserved only for bug reports, feature improvements and suggestions.
30
32
31
33
## <aname="filing-an-issue"></a>Filing an issue
32
-
Spotting imperfections and not keeping them to yourself is the first step to make this library better. We are very grateful for reports concerning imperfections in the source code or the [documentation]((https://getstream.io/chat/docs/sdk/react/)). Before filing an issue, please, review the list of [open issues](https://github.com/GetStream/stream-chat-react/issues) first.
34
+
35
+
Spotting imperfections and not keeping them to yourself is the first step to make this library better. We are very grateful for reports concerning imperfections in the source code or the [documentation](<(https://getstream.io/chat/docs/sdk/react/)>). Before filing an issue, please, review the list of [open issues](https://github.com/GetStream/stream-chat-react/issues) first.
33
36
34
37
### Reporting bugs
35
-
You can report a source code bug by using the [Bug Report template](https://github.com/GetStream/stream-chat-react/issues/new/choose). Make sure you include "steps to reproduce" section. Bug that cannot be reproduced cannot be solved.
36
38
37
-
Do not be afraid to report imperfections in our [documentation]((https://getstream.io/chat/docs/sdk/react/)) as well. In such case, please attach the `docs` tag to the issue.
39
+
You can report a source code bug by using the [Bug Report template](https://github.com/GetStream/stream-chat-react/issues/new/choose). Make sure you include "steps to reproduce" section. Bug that cannot be reproduced cannot be solved.
38
40
41
+
Do not be afraid to report imperfections in our [documentation](<(https://getstream.io/chat/docs/sdk/react/)>) as well. In such case, please attach the `docs` tag to the issue.
39
42
40
43
### Requesting a feature
44
+
41
45
You can request a feature by submitting a [Feature request issue](https://github.com/GetStream/stream-chat-react/issues/new?assignees=&labels=feature&template=feature_request.md&title=) in our repository. If you would like to implement the proposal, please state it in the issue. It will allow us to discuss the proposal and better coordinate the efforts. You can even ping us - mention `@GetStream/stream-react-developers ` in the issue.
42
46
43
47
## <aname="contribution-standards"></a> Contributing to the repo
44
48
45
49
### Set up for success
50
+
46
51
It is always good to get acquainted with the specifics of the package. For example the `stream-chat-react` package has its peer dependencies (`stream-chat-js`, `stream-chat-css`), which you may need to tweak at the same time, while developing the feature for `stream-chat-react`. To get more into those specifics, please read [development guide](./developers/DEVELOPMENT.md).
47
52
48
53
### Good first issue
@@ -51,28 +56,32 @@ It is always good to get acquainted with the specifics of the package. For examp
51
56
Any contributions to the library should follow Stream's coding rules.
52
57
53
58
#### 1. Code should be tested
59
+
54
60
All the code submitted should be covered by unit tests. Mocking utilities are provided in `src/mock-builders`. Optimally a suite of E2E tests should be included as well.
55
61
56
62
#### 2. API Changes should be documented
63
+
57
64
Changes to components interface exposed to the library integrators should be documented. We keep the documentation `docusaurus/docs/React` folder. Please see the [dedicated documentation guide](./developers/DOCUMENTATION.md) for more information on how to maintain our documentation.
58
65
59
66
#### 3. Code should be DRY & correctly formatted
67
+
60
68
If you find yourself copying source code from one place to another, please extract it into a separate component or function.
61
69
62
70
#### 4. Keep an eye on performance
71
+
63
72
Keep in mind that the chat application may need to work with thousands of messages.
64
73
65
74
#### 5. Follow commit formatting rules
66
-
We follow [Angular's Commit Message Format rules](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-format) with [possible deviations](./developers/COMMIT.md). The same rules are used by our release automation tool. Therefore, every commit message should strictly comply with these rules.
67
75
76
+
We follow [Angular's Commit Message Format rules](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-format) with [possible deviations](./developers/COMMIT.md). The same rules are used by our release automation tool. Therefore, every commit message should strictly comply with these rules.
68
77
69
78
## <aname="submission-guidelines"></a> Submitting your work
79
+
70
80
1. Make sure you have signed our Contributor License agreement
71
81
2.[Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo) the repo and create a dedicated git branch locally
72
82
3. Follow the [coding rules](#coding-rules)
73
83
4. Create a descriptive PR ([see more on PR requirements](./developers/PR_REVIEW.md))
Before we can merge your contribution into our repository, we would like to ask you to sign the [Contributor License Agreement](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform).
78
86
87
+
Before we can merge your contribution into our repository, we would like to ask you to sign the [Contributor License Agreement](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform).
0 commit comments