feat: add customizable reactions sorting #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
commented
Feb 21, 2024
| }, | ||
| ); | ||
|
|
||
| return unsortedReactions.sort(sortReactions); |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2289 +/- ##
=======================================
Coverage 85.00% 85.01%
=======================================
Files 344 344
Lines 7675 7680 +5
Branches 2135 2136 +1
=======================================
+ Hits 6524 6529 +5
Misses 807 807
Partials 344 344 ☔ View full report in Codecov by Sentry. |
|
Size Change: +614 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
myandrienko
requested review from
MartinCupela,
oliverlaz and
arnautov-anton
MartinCupela
approved these changes
Feb 22, 2024
myandrienko
added a commit
that referenced
this pull request
Feb 22, 2024
This is a follow-up to 🚂 #2289. Same thing, but for the list of reacted users inside the reactions list modal.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
## [11.10.0](v11.9.0...v11.10.0) (2024-02-23) ### Bug Fixes * initial message load issues ([#2292](#2292)) ([3685030](3685030)) ### Features * add customizable reaction details sorting ([#2290](#2290)) ([652e3a5](652e3a5)), closes [#2289](#2289) * add customizable reactions sorting ([#2289](#2289)) ([78c6107](78c6107))
|
🎉 This PR is included in version 11.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently the order of reactions in the
ReactionsListdepends of the order of keys in thereaction_countsobject returned by the backend. This leads to unstable reaction order, which can change on page reloads, or when the list of reactions changes.We want to provide a way to customize this behavior, and to have a stable order of reactions by default.
🛠 Implementation details
Added a new
MessageContextproperty:sortReactions. It accepts two reaction objects, and should return a positive/negative/zero numeric value, similar to theArray.prototype.sortmethod.The
sortReactionsprop can be passed both toMessageListandVirtualizedMessageList, as well as to theMessagecomponent directly. It will then be available via theMessageContext.