feat: support size_limit in upload config #2301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
force-pushed
the
feat/file-size-limit
branch
from
33a2a8d to
bd258cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2301 +/- ##
==========================================
+ Coverage 85.08% 85.22% +0.14%
==========================================
Files 353 353
Lines 8039 8049 +10
Branches 2120 2122 +2
==========================================
+ Hits 6840 6860 +20
+ Misses 1013 1005 -8
+ Partials 186 184 -2 ☔ View full report in Codecov by Sentry. |
|
Size Change: +1.59 kB (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
MartinCupela
reviewed
Apr 8, 2024
| return true; | ||
| }; | ||
|
|
||
| function prettifyFileSize(bytes: number) { |
There was a problem hiding this comment.
We could reuse this function also for file size in message attachments.
There was a problem hiding this comment.
AFAIK, none of our default attachment components show file size.
There was a problem hiding this comment.
Oh no, my mistake - we do. Will update.
|
@myandrienko could you please add tests? |
oliverlaz
approved these changes
Apr 8, 2024
myandrienko
added a commit
that referenced
this pull request
Apr 8, 2024
Quick fix for some stuff that got broken after removing `pretty-bytes` in #2301: 1. Sizes are now 1024-based (as opposed for 1000-based) to align with backend. 2. Add support for zero-precision,
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
## [11.14.0](v11.13.1...v11.14.0) (2024-04-08) ### Bug Fixes * add missing PinIndicator placeholder ([#2352](#2352)) ([e059af8](e059af8)) * file size formatting ([#2357](#2357)) ([7e98a85](7e98a85)), closes [#2301](#2301) ### Features * support size_limit in upload config ([#2301](#2301)) ([a8aa524](a8aa524))
|
🎉 This PR is included in version 11.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
🎯 Goal
Support the newly introduced upload size limit setting.
🎨 UI Changes
To-Do