fix: cleanup ML types and defaults #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2305 +/- ##
=======================================
Coverage 85.04% 85.05%
=======================================
Files 344 344
Lines 7702 7706 +4
Branches 2143 2144 +1
=======================================
+ Hits 6550 6554 +4
Misses 806 806
Partials 346 346 ☔ View full report in Codecov by Sentry. |
|
Size Change: +280 B (0%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Mar 1, 2024
arnautov-anton
force-pushed
the
fix/ml-types-and-defaults
branch
from
7d6ac37 to
62d3114
Compare
|
🎉 This PR is included in version 11.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
## [11.11.0](v11.10.0...v11.11.0) (2024-03-01) ### Bug Fixes * cleanup ML types and defaults ([#2305](#2305)) ([b3ed81d](b3ed81d)) ### Features * introduce useCreateChatClient hook ([#1916](#1916)) ([e086565](e086565)), closes [GetStream/stream-chat-react-issues#19](https://github.com/GetStream/stream-chat-react-issues/issues/19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The main goal of this PR is to make the properties of the
internalInfiniteScrollPropsML property completely optional. As a side "task" I cleaned up the numeric default (not sure about the naming, feel free to suggest a better one).