fix: reflect Message groupStyles prop in the component memoization #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
approved these changes
Jul 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2448 +/- ##
===============================================
- Coverage 85.48% 85.46% -0.03%
===============================================
Files 393 393
Lines 9122 9123 +1
Branches 2356 2490 +134
===============================================
- Hits 7798 7797 -1
+ Misses 1122 927 -195
- Partials 202 399 +197 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
## [11.23.2](v11.23.1...v11.23.2) (2024-07-10) ### Bug Fixes * reflect Message groupStyles prop in the component memoization ([#2448](#2448)) ([251eb08](251eb08))
|
🎉 This PR is included in version 11.23.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
## [12.0.0-rc.3](v12.0.0-rc.2...v12.0.0-rc.3) (2024-07-10) ### ⚠ BREAKING CHANGES * MP3 audio encoder has to be explicitly imported and used as a plugin for audio recordings. The default audio recording format is audio/wav. * @breezystack/lamejs became a peer dependency and has to be installed by the integrator so that the MP3 audio encoder can work properly. * Removed fileOrder, imageOrder, fileUploads, imageUploads, uploadFile, uploadImage, removeFile, removeImage from the MessageInputContext. Use attachments, uploadAttachment, uploadNewFiles, upsertAttachments, removeAttachments instead. * Removed default values for timestamp formatting props like calendar or format for DateSeparator, EventComponent, MessageTimestamp. The formatting configuration now entirely relies on i18n translations. ### Bug Fixes * acknowledge the use of LAME ([dbce6dc](dbce6dc)) * extract MP3 encoder plugin ([#2447](#2447)) ([625196f](625196f)) * reflect Message groupStyles prop in the component memoization ([#2448](#2448)) ([251eb08](251eb08)) ### Features * keep attachments array and remove file and image uploads in MessageInput state ([#2445](#2445)) ([238e801](238e801)) * remove default timestamp formatting props from DateSeparator, EventComponent, MessageTimestamp ([#2442](#2442)) ([6431954](6431954))
|
🎉 This PR is included in version 12.0.0-rc.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Consider
groupStylesprop in Message UI component memoization, aka memoization strikes again.