-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit: fix deprecated stages #1029
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 181 181
Lines 7708 7708
=======================================
Hits 7094 7094
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @Crocmagnon , |
version 4.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I finally managed to reproduce and I can confirm your changes fit the warning.
Looking at a similar fix done by the pre-commit authors themselves, it looks like it is recommended to add a minimum_pre_commit_version: 3.2.0
entry for each hook. Can you look into this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Thank you for your quick feedback! :) |
Context
Fix deprecated pre-commit stages.
Fix #980
Validation
pre-commit run --all-files
Minimal config:
PR check list
skip-changelog
label has been added to the PR.❓ Does this require a changelog entry? I'd be tempted to say no but I don't know your policies.