fixup! [gncBillTerm.cpp] don't return invalid enum

christopherlam · christopherlam · commit 0d645314e5e4 · 2024-07-25T06:38:20.000+08:00
diff --git a/libgnucash/engine/gncBillTerm.cpp b/libgnucash/engine/gncBillTerm.cpp
@@ -538,7 +538,11 @@ const char *gncBillTermGetDescription (const GncBillTerm *term)
 
 GncBillTermType gncBillTermGetType (const GncBillTerm *term)
 {
-    if (!term) return GncBillTermType(0);
+    if (!term)
+    {
+        PERR ("term cannot be null");
+        return GNC_TERM_TYPE_DAYS;
+    }
     return term->type;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -538,7 +538,11 @@ const char gncBillTermGetDescription (const GncBillTerm term)`
`538`	`538`
`539`	`539`	`GncBillTermType gncBillTermGetType (const GncBillTerm *term)`
`540`	`540`	`{`
`541`		`- if (!term) return GncBillTermType(0);`
	`541`	`+ if (!term)`
	`542`	`+ {`
	`543`	`+ PERR ("term cannot be null");`
	`544`	`+ return GNC_TERM_TYPE_DAYS;`
	`545`	`+ }`
`542`	`546`	`return term->type;`
`543`	`547`	`}`
`544`	`548`